Skip to content

Add no_std support to bevy_state#17028

Merged
alice-i-cecile merged 4 commits intobevyengine:mainfrom
bushrat011899:NoSTDBevyState
Dec 29, 2024
Merged

Add no_std support to bevy_state#17028
alice-i-cecile merged 4 commits intobevyengine:mainfrom
bushrat011899:NoSTDBevyState

Conversation

@bushrat011899
Copy link
Copy Markdown
Contributor

Objective

Solution

  • Added the following features:
    • std (default)
    • portable-atomic
    • critical-section

Testing

  • CI

Notes

  • portable-atomic, and critical-section are shortcuts to enable the relevant features in dependencies, making the usage of this crate on atomically challenged platforms possible and simpler.
  • This PR is blocked until Add portable-atomic support to bevy_utils for once! #17027 is merged (as it depends on fixes for the once! macro). Once merged, the change-count for this PR should reduce.

@bushrat011899 bushrat011899 added C-Feature A new feature, making something new possible S-Blocked This cannot move forward until something else changes X-Uncontroversial This work is generally agreed upon D-Straightforward Simple bug fixes and API improvements, docs, test and examples A-States App-level states machines labels Dec 29, 2024
@alice-i-cecile alice-i-cecile added this to the 0.16 milestone Dec 29, 2024
@alice-i-cecile alice-i-cecile added S-Needs-Review Needs reviewer attention (from anyone!) to move forward and removed S-Blocked This cannot move forward until something else changes labels Dec 29, 2024
Copy link
Copy Markdown
Contributor

@BenjaminBrienen BenjaminBrienen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy one!

@bushrat011899 bushrat011899 added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 29, 2024
@alice-i-cecile
Copy link
Copy Markdown
Member

@bushrat011899 ping me to merge this once merge conflicts are resolved please :)

@bushrat011899
Copy link
Copy Markdown
Contributor Author

@alice-i-cecile Conflicts resolved! It's a shame the git algorithm can't handle the way I add tests to that compile-check-no-std command, but at least it's an easy resolve.

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Dec 29, 2024
Merged via the queue into bevyengine:main with commit 79a367d Dec 29, 2024
@TimJentzsch TimJentzsch added the O-Embedded Weird hardware and no_std platforms label Dec 31, 2024
ecoskey pushed a commit to ecoskey/bevy that referenced this pull request Jan 6, 2025
# Objective

- Contributes to bevyengine#15460

## Solution

- Added the following features:
  - `std` (default)
  - `portable-atomic`
  - `critical-section`

## Testing

- CI

## Notes

- `portable-atomic`, and `critical-section` are shortcuts to enable the
relevant features in dependencies, making the usage of this crate on
atomically challenged platforms possible and simpler.
- This PR is blocked until bevyengine#17027 is merged (as it depends on fixes for
the `once!` macro). Once merged, the change-count for this PR should
reduce.
mrchantey pushed a commit to mrchantey/bevy that referenced this pull request Feb 4, 2025
# Objective

- Contributes to bevyengine#15460

## Solution

- Added the following features:
  - `std` (default)
  - `portable-atomic`
  - `critical-section`

## Testing

- CI

## Notes

- `portable-atomic`, and `critical-section` are shortcuts to enable the
relevant features in dependencies, making the usage of this crate on
atomically challenged platforms possible and simpler.
- This PR is blocked until bevyengine#17027 is merged (as it depends on fixes for
the `once!` macro). Once merged, the change-count for this PR should
reduce.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-States App-level states machines C-Feature A new feature, making something new possible D-Straightforward Simple bug fixes and API improvements, docs, test and examples O-Embedded Weird hardware and no_std platforms S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it X-Uncontroversial This work is generally agreed upon

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants