Add portable-atomic support to bevy_utils for once!#17027
Merged
alice-i-cecile merged 2 commits intobevyengine:mainfrom Dec 29, 2024
Merged
Add portable-atomic support to bevy_utils for once!#17027alice-i-cecile merged 2 commits intobevyengine:mainfrom
portable-atomic support to bevy_utils for once!#17027alice-i-cecile merged 2 commits intobevyengine:mainfrom
Conversation
alice-i-cecile
approved these changes
Dec 29, 2024
Member
alice-i-cecile
left a comment
There was a problem hiding this comment.
Very nice :) I particularly appreciate the docs on the features.
Contributor
|
I think eventually we should have this kind of code live in a |
BenjaminBrienen
approved these changes
Dec 29, 2024
Contributor
Author
Totally agree, just wanted to sneak this change in as-is to unblock #17028. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 29, 2024
# Objective - Contributes to #15460 ## Solution - Added the following features: - `std` (default) - `portable-atomic` - `critical-section` ## Testing - CI ## Notes - `portable-atomic`, and `critical-section` are shortcuts to enable the relevant features in dependencies, making the usage of this crate on atomically challenged platforms possible and simpler. - This PR is blocked until #17027 is merged (as it depends on fixes for the `once!` macro). Once merged, the change-count for this PR should reduce.
ecoskey
pushed a commit
to ecoskey/bevy
that referenced
this pull request
Jan 6, 2025
…#17027) # Objective - Improves platform compatibility for `bevy_utils` ## Solution - Added `portable-atomic` to allow using the `once!` macro on more platforms (e.g., Raspberry Pi Pico) ## Testing - CI ## Notes - This change should be entirely hidden thanks to the use of `doc(hidden)`. Enabling the new `portable-atomic` feature just allows using the `once!` macro on platforms which previously could not. - I took the liberty of updating the feature documentation to be more in line with how I've documented features in `bevy_ecs`/`bevy_app`/etc. for their `no_std` updates.
ecoskey
pushed a commit
to ecoskey/bevy
that referenced
this pull request
Jan 6, 2025
# Objective - Contributes to bevyengine#15460 ## Solution - Added the following features: - `std` (default) - `portable-atomic` - `critical-section` ## Testing - CI ## Notes - `portable-atomic`, and `critical-section` are shortcuts to enable the relevant features in dependencies, making the usage of this crate on atomically challenged platforms possible and simpler. - This PR is blocked until bevyengine#17027 is merged (as it depends on fixes for the `once!` macro). Once merged, the change-count for this PR should reduce.
mrchantey
pushed a commit
to mrchantey/bevy
that referenced
this pull request
Feb 4, 2025
…#17027) # Objective - Improves platform compatibility for `bevy_utils` ## Solution - Added `portable-atomic` to allow using the `once!` macro on more platforms (e.g., Raspberry Pi Pico) ## Testing - CI ## Notes - This change should be entirely hidden thanks to the use of `doc(hidden)`. Enabling the new `portable-atomic` feature just allows using the `once!` macro on platforms which previously could not. - I took the liberty of updating the feature documentation to be more in line with how I've documented features in `bevy_ecs`/`bevy_app`/etc. for their `no_std` updates.
mrchantey
pushed a commit
to mrchantey/bevy
that referenced
this pull request
Feb 4, 2025
# Objective - Contributes to bevyengine#15460 ## Solution - Added the following features: - `std` (default) - `portable-atomic` - `critical-section` ## Testing - CI ## Notes - `portable-atomic`, and `critical-section` are shortcuts to enable the relevant features in dependencies, making the usage of this crate on atomically challenged platforms possible and simpler. - This PR is blocked until bevyengine#17027 is merged (as it depends on fixes for the `once!` macro). Once merged, the change-count for this PR should reduce.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
bevy_utilsSolution
portable-atomicto allow using theonce!macro on more platforms (e.g., Raspberry Pi Pico)Testing
Notes
doc(hidden). Enabling the newportable-atomicfeature just allows using theonce!macro on platforms which previously could not.bevy_ecs/bevy_app/etc. for theirno_stdupdates.