Move EntityHash related types into bevy_ecs#11498
Merged
alice-i-cecile merged 19 commits intobevyengine:mainfrom Feb 12, 2024
Merged
Move EntityHash related types into bevy_ecs#11498alice-i-cecile merged 19 commits intobevyengine:mainfrom
EntityHash related types into bevy_ecs#11498alice-i-cecile merged 19 commits intobevyengine:mainfrom
Conversation
SkiFire13
reviewed
Jan 23, 2024
SkiFire13
reviewed
Jan 23, 2024
james7132
approved these changes
Jan 29, 2024
Member
james7132
left a comment
There was a problem hiding this comment.
LGTM, though the migration guide should mention that EntityHashMap now only has one generic argument (the value type), instead of two.
SkiFire13
approved these changes
Feb 9, 2024
Contributor
|
The migration guide could be changed to mention what needs to be adapter for the new changes, rather than the new changes themself. For example:
|
Member
|
CI failure is real: looks like you forgot to feature flag imports. |
Contributor
Author
|
It doesn't look like my problem. If it is, what am I doing wrong? |
SkiFire13
suggested changes
Feb 12, 2024
Contributor
SkiFire13
left a comment
There was a problem hiding this comment.
These should be the cause of the CI failure.
alice-i-cecile
approved these changes
Feb 12, 2024
Member
alice-i-cecile
left a comment
There was a problem hiding this comment.
Second time's the charm.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 3, 2024
# Objective - Follow-up on some changes in #11498 - Unblock using `Identifier` to replace `ComponentId` internals. ## Solution - Implement the same `Reflect` impls from `Entity` onto `Identifier` as they share same/similar purposes, ## Testing - No compile errors. Currently `Identifier` has no serialization impls, so there's no need to test a serialization/deserialization roundtrip to ensure correctness. --- ## Changelog ### Added - Reflection implementations on `Identifier`.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 9, 2024
# Objective `EntityHash` and related types were moved from `bevy_utils` to `bevy_ecs` in #11498, but seemed to have been accidentally reintroduced a week later in #11707. ## Solution Remove the old leftover code. --- ## Migration Guide - Uses of `bevy::utils::{EntityHash, EntityHasher, EntityHashMap, EntityHashSet}` now have to be imported from `bevy::ecs::entity`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Reduce the size of
bevy_utils(#11478)Solution
Move
EntityHashrelated types intobevy_ecs. This also allows us access toEntity, which means we no longer needEntityHashMap's first generic argument.Changelog
bevy::utils::{EntityHash, EntityHasher, EntityHashMap, EntityHashSet}intobevy::ecs::entity::hash.EntityHashMap's first generic argument. It is now hardcoded to always beEntity.Migration Guide
bevy::utils::{EntityHash, EntityHasher, EntityHashMap, EntityHashSet}now have to be imported frombevy::ecs::entity::hash.EntityHashMapno longer have to specify the first generic parameter. It is now hardcoded to always beEntity.