feat: Reflection implementations on Identifier#13648
Merged
alice-i-cecile merged 3 commits intobevyengine:mainfrom Jun 3, 2024
Merged
feat: Reflection implementations on Identifier#13648alice-i-cecile merged 3 commits intobevyengine:mainfrom
alice-i-cecile merged 3 commits intobevyengine:mainfrom
Conversation
alice-i-cecile
approved these changes
Jun 3, 2024
Member
|
Merging as trivial. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
EntityHashrelated types intobevy_ecs#11498Identifierto replaceComponentIdinternals.Solution
Reflectimpls fromEntityontoIdentifieras they share same/similar purposes,Testing
Identifierhas no serialization impls, so there's no need to test a serialization/deserialization roundtrip to ensure correctness.Changelog
Added
Identifier.