Skip to content

feat: Reflection implementations on Identifier#13648

Merged
alice-i-cecile merged 3 commits intobevyengine:mainfrom
Bluefinger:identifier-reflection
Jun 3, 2024
Merged

feat: Reflection implementations on Identifier#13648
alice-i-cecile merged 3 commits intobevyengine:mainfrom
Bluefinger:identifier-reflection

Conversation

@Bluefinger
Copy link
Copy Markdown
Contributor

Objective

Solution

  • Implement the same Reflect impls from Entity onto Identifier as they share same/similar purposes,

Testing

  • No compile errors. Currently Identifier has no serialization impls, so there's no need to test a serialization/deserialization roundtrip to ensure correctness.

Changelog

Added

  • Reflection implementations on Identifier.

@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use A-Reflection Runtime information about types labels Jun 3, 2024
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jun 3, 2024
@alice-i-cecile
Copy link
Copy Markdown
Member

Merging as trivial.

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jun 3, 2024
Merged via the queue into bevyengine:main with commit 36f2542 Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ECS Entities, components, systems, and events A-Reflection Runtime information about types C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants