Update script.php#40
Conversation
|
script.php only runs on updates. |
|
@brianteeman I am testing updateing a staging or 3.9.x to 4.0-dev, and this has to work and works with 4.0-dev, @wilsonge please confirm!!! It works and the backend template shall not break that and with my corrections this is fulfilled. You can use my modified container linked above for testing. |
|
I stand by my statement above |
|
@brianteeman Ask Geogre if you don't believe me. He had merged one PRs to make that work and the backend template breaks this without my changes. |
|
@brianteeman Sure later people shall not update from 3.9 to 4.0. But updates from 3.10 to 4.0 shall work, and also when 4.0 has beta status, updates from beta to beta have to work. Therefore George has once made an issue to fix the schema updates for postgreSQL, see joomla#25467, and there were also other PRs and issues related to making the updates to 4.0 work. It does not matter if I use a staging or 3.9 or 3.10 for testing. Staging is best because contains latest fixes, while 3.10 is old. My changes here are necessary to keep those updates working, otherwise the backend-template would break that by erroneous schema update SQL and by deleting a module in script.php which is used by the new backend. So please @brianteeman think ti over and check these my PRs here and not hold on such formal thing like "he tested with staging and officially we do not supoort that". And please @wilsonge help me to convince him. |
|
And I have all tested like described here joomla#25467 on both MySQL and PostgreSQL. All the 4 open PRs here, one by one. |
|
I am saying that you are wasting your time writing this PR and asking us to waste our time in testing it |
|
I never asked you to test it. |
|
forgive me for trying to save you wasting your time |
|
This is fine. I have an updated version of the deleted file check as a WIP here joomla#25559 so it's not as important as the sql changes. But nothing wrong with getting this into the main PR |
* move to it own field * move to it own field * fix since * $modalHTML * init html and drone * drone ... * Move modal to field renderer (#40) * Move modal to field renderer * Fix var type * Fix wrong variable * __DEPLOY_VERSION__
…44675) * com_contenthistory-admin-test: Add Cypress test for Content History * cs * wait for #40 * single-quotes * open history content in modal * actions-on-history-item * wait-pr-40 * remove-todo * joomla-cypress to version 1.3.0 * retry * delete-last * aftereach * undo --------- Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com>
Pull Request (PR) for joomla#25570.
Summary of Changes
Don't remove anymore mod_submenu with script.php after updates but remove mod_status.
This should fix the empty help and system views, see my comment here: #37 (comment) and here #37 (comment).
Testing Instructions
Code review, or test updateing from staging with a modified update container.
Update: Just tested, it solves the problem.