Skip to content

Update to container-structure-test 1.8.0#685

Merged
xingao267 merged 4 commits intobazelbuild:masterfrom
briandealwis:cst170
Feb 21, 2019
Merged

Update to container-structure-test 1.8.0#685
xingao267 merged 4 commits intobazelbuild:masterfrom
briandealwis:cst170

Conversation

@briandealwis
Copy link
Contributor

@briandealwis briandealwis commented Feb 6, 2019 •
edited
Loading

container-structure-test 1.7.0 adds the ability to test image metadata with regexs.

Updated to container-structure-test v1.8.0, which pulls in the 0-byte layer.tar fix from
google/go-containerregistry

@k8s-ci-robot
Copy link

k8s-ci-robot commented Feb 6, 2019

Hi @briandealwis. Thanks for your PR.

I'm waiting for a bazelbuild member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@briandealwis briandealwis mentioned this pull request Feb 6, 2019
Merged
@nlopezgi
Copy link
Contributor

nlopezgi commented Feb 6, 2019

looks like the windows tests are failing, the error message is not too descriptive, but does seem to point to 1.7.0 being problematic

@briandealwis
Copy link
Contributor Author

briandealwis commented Feb 6, 2019

Too bad the tests are run with --quiet! I can reproduce locally:

$ bazel-out/darwin-fastbuild/bin/structure_test_at_workspace_root.runfiles/structure_test_darwin/file/downloaded version
v1.7.0
$ bazel-out/darwin-fastbuild/bin/structure_test_at_workspace_root.runfiles/structure_test_darwin/file/downloaded test --driver tar --image bazel-out/darwin-fastbuild/bin/tests/docker/basic_windows_image.tar --config tests/docker/configs/windows_image.yaml

===========================================
====== Test file: windows_image.yaml ======
===========================================
=== RUN: Files
--- FAIL
Error: error creating driver: processing tar image reference: retrieving tar from path: EOF

=== RUN: Hives
--- FAIL
Error: error creating driver: processing tar image reference: retrieving tar from path: EOF

=== RUN: Metadata Test
--- FAIL
Error: error creating driver: processing tar image reference: retrieving tar from path: EOF


===========================================
================= RESULTS =================
===========================================
Passes:      0
Failures:    3
Total tests: 3

FAIL
FATA[0000] FAIL

@briandealwis
Copy link
Contributor Author

briandealwis commented Feb 6, 2019

I'm assuming the local failure is the same as what's happening on the build machine. It's odd that the other builds all pass though.

@briandealwis briandealwis mentioned this pull request Feb 6, 2019
Closed
@briandealwis
Copy link
Contributor Author

briandealwis commented Feb 6, 2019 •
edited
Loading

I opened GoogleContainerTools/container-structure-test#197 and did some initial digging.

It turns out that the generated Windows images have 0-byte layer.tar files which seems … unusual?

$ tar tvf bazel-out/darwin-fastbuild/bin/tests/docker/basic_windows_image.tar 
-rw-r--r--  0 0      0         907 31 Dec  1969 378fb1f1c5d59102b2b942e7c5cd76ce913cb5a4b74e97f87041dc61ab14b21e.json
-rw-r--r--  0 0      0           3 31 Dec  1969 0239ecd27132f0d70c7946a5365ef1f0a3edc7ecf6bdeeb61b4215598beb9828/VERSION
-rw-r--r--  0 0      0       10240 31 Dec  1969 0239ecd27132f0d70c7946a5365ef1f0a3edc7ecf6bdeeb61b4215598beb9828/layer.tar
-rw-r--r--  0 0      0         461 31 Dec  1969 0239ecd27132f0d70c7946a5365ef1f0a3edc7ecf6bdeeb61b4215598beb9828/json
-rw-r--r--  0 0      0           3 31 Dec  1969 54625cd3a0909e177f99d40c983676e65cd2ba5e3231670bd3b3a060463e384c/VERSION
-rw-r--r--  0 0      0           0 31 Dec  1969 54625cd3a0909e177f99d40c983676e65cd2ba5e3231670bd3b3a060463e384c/layer.tar
-rw-r--r--  0 0      0         250 31 Dec  1969 54625cd3a0909e177f99d40c983676e65cd2ba5e3231670bd3b3a060463e384c/json
-rw-r--r--  0 0      0           3 31 Dec  1969 fa2da5bcc17fb2e5c2025c1b76104bdd0f5b9ce64d6d4b29762e58aa11d97ee8/VERSION
-rw-r--r--  0 0      0           0 31 Dec  1969 fa2da5bcc17fb2e5c2025c1b76104bdd0f5b9ce64d6d4b29762e58aa11d97ee8/layer.tar
-rw-r--r--  0 0      0         178 31 Dec  1969 fa2da5bcc17fb2e5c2025c1b76104bdd0f5b9ce64d6d4b29762e58aa11d97ee8/json
-rw-r--r--  0 0      0         115 31 Dec  1969 repositories
-rw-r--r--  0 0      0        1037 31 Dec  1969 manifest.json

Here's what happens:

@k8s-ci-robot
Copy link

k8s-ci-robot commented Feb 6, 2019

@briandealwis: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

I opened GoogleContainerTools/container-structure-test#197 and did some initial digging.

It turns out that the generated Windows images have 0-byte layer.tar files which seems … unusual?

$ tar bazel-out/darwin-fastbuild/bin/tests/docker/basic_windows_image.tar 
-rw-r--r--  0 0      0         907 31 Dec  1969 378fb1f1c5d59102b2b942e7c5cd76ce913cb5a4b74e97f87041dc61ab14b21e.json
-rw-r--r--  0 0      0           3 31 Dec  1969 0239ecd27132f0d70c7946a5365ef1f0a3edc7ecf6bdeeb61b4215598beb9828/VERSION
-rw-r--r--  0 0      0       10240 31 Dec  1969 0239ecd27132f0d70c7946a5365ef1f0a3edc7ecf6bdeeb61b4215598beb9828/layer.tar
-rw-r--r--  0 0      0         461 31 Dec  1969 0239ecd27132f0d70c7946a5365ef1f0a3edc7ecf6bdeeb61b4215598beb9828/json
-rw-r--r--  0 0      0           3 31 Dec  1969 54625cd3a0909e177f99d40c983676e65cd2ba5e3231670bd3b3a060463e384c/VERSION
-rw-r--r--  0 0      0           0 31 Dec  1969 54625cd3a0909e177f99d40c983676e65cd2ba5e3231670bd3b3a060463e384c/layer.tar
-rw-r--r--  0 0      0         250 31 Dec  1969 54625cd3a0909e177f99d40c983676e65cd2ba5e3231670bd3b3a060463e384c/json
-rw-r--r--  0 0      0           3 31 Dec  1969 fa2da5bcc17fb2e5c2025c1b76104bdd0f5b9ce64d6d4b29762e58aa11d97ee8/VERSION
-rw-r--r--  0 0      0           0 31 Dec  1969 fa2da5bcc17fb2e5c2025c1b76104bdd0f5b9ce64d6d4b29762e58aa11d97ee8/layer.tar
-rw-r--r--  0 0      0         178 31 Dec  1969 fa2da5bcc17fb2e5c2025c1b76104bdd0f5b9ce64d6d4b29762e58aa11d97ee8/json
-rw-r--r--  0 0      0         115 31 Dec  1969 repositories
-rw-r--r--  0 0      0        1037 31 Dec  1969 manifest.json

Here's what happens:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link

k8s-ci-robot commented Feb 6, 2019

@briandealwis: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

I opened GoogleContainerTools/container-structure-test#197 and did some initial digging.

It turns out that the generated Windows images have 0-byte layer.tar files:

$ tar bazel-out/darwin-fastbuild/bin/tests/docker/basic_windows_image.tar 
-rw-r--r--  0 0      0         907 31 Dec  1969 378fb1f1c5d59102b2b942e7c5cd76ce913cb5a4b74e97f87041dc61ab14b21e.json
-rw-r--r--  0 0      0           3 31 Dec  1969 0239ecd27132f0d70c7946a5365ef1f0a3edc7ecf6bdeeb61b4215598beb9828/VERSION
-rw-r--r--  0 0      0       10240 31 Dec  1969 0239ecd27132f0d70c7946a5365ef1f0a3edc7ecf6bdeeb61b4215598beb9828/layer.tar
-rw-r--r--  0 0      0         461 31 Dec  1969 0239ecd27132f0d70c7946a5365ef1f0a3edc7ecf6bdeeb61b4215598beb9828/json
-rw-r--r--  0 0      0           3 31 Dec  1969 54625cd3a0909e177f99d40c983676e65cd2ba5e3231670bd3b3a060463e384c/VERSION
-rw-r--r--  0 0      0           0 31 Dec  1969 54625cd3a0909e177f99d40c983676e65cd2ba5e3231670bd3b3a060463e384c/layer.tar
-rw-r--r--  0 0      0         250 31 Dec  1969 54625cd3a0909e177f99d40c983676e65cd2ba5e3231670bd3b3a060463e384c/json
-rw-r--r--  0 0      0           3 31 Dec  1969 fa2da5bcc17fb2e5c2025c1b76104bdd0f5b9ce64d6d4b29762e58aa11d97ee8/VERSION
-rw-r--r--  0 0      0           0 31 Dec  1969 fa2da5bcc17fb2e5c2025c1b76104bdd0f5b9ce64d6d4b29762e58aa11d97ee8/layer.tar
-rw-r--r--  0 0      0         178 31 Dec  1969 fa2da5bcc17fb2e5c2025c1b76104bdd0f5b9ce64d6d4b29762e58aa11d97ee8/json
-rw-r--r--  0 0      0         115 31 Dec  1969 repositories
-rw-r--r--  0 0      0        1037 31 Dec  1969 manifest.json

Here's what happens:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@briandealwis briandealwis mentioned this pull request Feb 12, 2019
Closed
@briandealwis
Copy link
Contributor Author

briandealwis commented Feb 12, 2019

So it seems 0-byte layer.tar files are considered valid.
Ah, container-structure-test switched to using go-containerregistry in v1.6.0.

I've opened google/go-containerregistry#367

@briandealwis briandealwis changed the title Update to container-structure-test 1.7.0 Update to container-structure-test 1.8.0 Feb 21, 2019
@briandealwis
Copy link
Contributor Author

briandealwis commented Feb 21, 2019

container-structure-test v1.8.0 has been released, which fixes the odd test failure, and the tests now pass. PTAL @nlopezgi

@k8s-ci-robot
Copy link

k8s-ci-robot commented Feb 21, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: briandealwis, xingao267
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:

If they are not already assigned, you can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xingao267 xingao267 merged commit 10ac85c into bazelbuild:master Feb 21, 2019
@briandealwis briandealwis deleted the cst170 branch February 22, 2019 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alex1545 alex1545 Awaiting requested review from alex1545

@mattmoor mattmoor Awaiting requested review from mattmoor

@nlopezgi nlopezgi Awaiting requested review from nlopezgi

@smukherj1 smukherj1 Awaiting requested review from smukherj1 smukherj1 is a code owner

1 more reviewer

@xingao267 xingao267 xingao267 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@xingao267 xingao267

Labels

cla: yes lgtm needs-ok-to-test size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@briandealwis @k8s-ci-robot @nlopezgi @xingao267 @googlebot