Use go-containerregistry image processing from container-diff#181
Merged
nkubala merged 2 commits intoGoogleContainerTools:masterfrom Oct 31, 2018
Merged
Use go-containerregistry image processing from container-diff#181nkubala merged 2 commits intoGoogleContainerTools:masterfrom
nkubala merged 2 commits intoGoogleContainerTools:masterfrom
Conversation
…ry image processing
ea7b309 to
cba6d0d
Compare
cba6d0d to
2b3e2d9
Compare
dlorenc
approved these changes
Oct 31, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change integrates the latest version of container-diff, which cleans up the image processing and lets go-containerregistry do most of the work.
Since we don't have
Prepperto use directly anymore, we'll use the prefix heuristic from container-diff to try to infer the source of the image, starting with the local docker daemon and then trying from remote. Eventually, we might want to split this logic up in container-diff so we can call something likeGetImageFromRemoteorGetImageFromDaemondirectly.It might also be worth considering moving the
GetImageFromXXXlogic into go-containerregistry, since it's really just a glorified wrapper aroundmutate.Extract.