Wrapping all enums in messages for clarity in C++/Py.#85
Merged
ola-rozenfeld merged 1 commit intobazelbuild:masterfrom Jun 6, 2019
Merged
Wrapping all enums in messages for clarity in C++/Py.#85ola-rozenfeld merged 1 commit intobazelbuild:masterfrom
ola-rozenfeld merged 1 commit intobazelbuild:masterfrom
Conversation
bergsieker
approved these changes
Jun 3, 2019
Contributor
|
Is this change backwards compatible? |
Contributor
Author
|
Yes, none of the enum values changed, so it should be. The rollout plan is:
WDYT? |
Contributor
|
Why is there a need for a roll out plan if this change is wire compatible? |
Contributor
Author
|
Because it breaks compile on clients and servers alike, and in our particular case we have a rather weird dependency tree: RBE and internal Bazel depend on internal remote-apis, while external Bazel depends on its own copy of external remote-apis. So it's hardest for us, but for example for Buildfarm upgrading to this commit it should be a very simple single patch. |
Contributor
|
LGTM |
ola-rozenfeld
pushed a commit
to ola-rozenfeld/bazel
that referenced
this pull request
Jun 5, 2019
Change-Id: I48ec300dd5eb2158ece0eea3e27098c45a5ca7be
ola-rozenfeld
pushed a commit
to ola-rozenfeld/bazel
that referenced
this pull request
Jun 5, 2019
Change-Id: I48ec300dd5eb2158ece0eea3e27098c45a5ca7be
buchgr
approved these changes
Jun 6, 2019
Contributor
|
I think you need to sync it because I merged the VSO hash |
ola-rozenfeld
pushed a commit
to ola-rozenfeld/bazel
that referenced
this pull request
Jun 6, 2019
Change-Id: I48ec300dd5eb2158ece0eea3e27098c45a5ca7be
ola-rozenfeld
pushed a commit
to ola-rozenfeld/bazel
that referenced
this pull request
Jun 6, 2019
This requires both proto changes and code changes. The code changes will be submitted separately (and shortly) internally after the proto changes, temporarily breaking CI. Passing CI with both code and proto changes: https://buildkite.com/bazel/bazel-bazel-github-presubmit/builds/3235 Change-Id: I56313ae1173502d2fcfc78be8222f53708d9b298
bazel-io
pushed a commit
to bazelbuild/bazel
that referenced
this pull request
Jun 11, 2019
Change-Id: I48ec300dd5eb2158ece0eea3e27098c45a5ca7be Closes #8566. Change-Id: I48ec300dd5eb2158ece0eea3e27098c45a5ca7be PiperOrigin-RevId: 252625845
bazel-io
pushed a commit
to bazelbuild/bazel
that referenced
this pull request
Jun 11, 2019
irengrig
pushed a commit
to irengrig/bazel
that referenced
this pull request
Jun 18, 2019
Change-Id: I48ec300dd5eb2158ece0eea3e27098c45a5ca7be Closes bazelbuild#8566. Change-Id: I48ec300dd5eb2158ece0eea3e27098c45a5ca7be PiperOrigin-RevId: 252625845
irengrig
pushed a commit
to irengrig/bazel
that referenced
this pull request
Jun 18, 2019
siberex
pushed a commit
to siberex/bazel
that referenced
this pull request
Jul 4, 2019
Change-Id: I48ec300dd5eb2158ece0eea3e27098c45a5ca7be Closes bazelbuild#8566. Change-Id: I48ec300dd5eb2158ece0eea3e27098c45a5ca7be PiperOrigin-RevId: 252625845
siberex
pushed a commit
to siberex/bazel
that referenced
this pull request
Jul 4, 2019
irengrig
pushed a commit
to irengrig/bazel
that referenced
this pull request
Jul 15, 2019
Change-Id: I48ec300dd5eb2158ece0eea3e27098c45a5ca7be Closes bazelbuild#8566. Change-Id: I48ec300dd5eb2158ece0eea3e27098c45a5ca7be PiperOrigin-RevId: 252625845
irengrig
pushed a commit
to irengrig/bazel
that referenced
this pull request
Jul 15, 2019
santigl
pushed a commit
to santigl/remote-apis
that referenced
this pull request
Aug 26, 2020
luca-digrazia
pushed a commit
to luca-digrazia/DatasetCommitsDiffSearch
that referenced
this pull request
Sep 4, 2022
Change-Id: I48ec300dd5eb2158ece0eea3e27098c45a5ca7be
Closes #8566.
Change-Id: I48ec300dd5eb2158ece0eea3e27098c45a5ca7be
PiperOrigin-RevId: 252625845
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #56.