Import of https://github.com/bazelbuild/remote-apis/pull/85 into Bazel.#8566
Closed
ola-rozenfeld wants to merge 1 commit intobazelbuild:masterfrom
Closed
Import of https://github.com/bazelbuild/remote-apis/pull/85 into Bazel.#8566ola-rozenfeld wants to merge 1 commit intobazelbuild:masterfrom
ola-rozenfeld wants to merge 1 commit intobazelbuild:masterfrom
Conversation
Contributor
Author
|
Wait please, this is not ready for review yet, I'm still figuring out the correct submission order. Will update. |
Contributor
Author
|
https://buildkite.com/bazel/bazel-bazel-github-presubmit/builds/3235 passed. Now I will remove the source files from this patch, and then we will need to merge this and right away submit the internal change (which will have the source files). I think I can have all approvals by tomorrow, and then we can do this tomorrow. |
This requires both proto changes and code changes. The code changes will be submitted separately (and shortly) internally after the proto changes, temporarily breaking CI. Passing CI with both code and proto changes: https://buildkite.com/bazel/bazel-bazel-github-presubmit/builds/3235 Change-Id: I56313ae1173502d2fcfc78be8222f53708d9b298
Contributor
Author
|
Removed the source file changes. Now CI will fail, as expected. |
Contributor
Author
|
Jakob, ping! |
irengrig
pushed a commit
to irengrig/bazel
that referenced
this pull request
Jun 18, 2019
Change-Id: I48ec300dd5eb2158ece0eea3e27098c45a5ca7be Closes bazelbuild#8566. Change-Id: I48ec300dd5eb2158ece0eea3e27098c45a5ca7be PiperOrigin-RevId: 252625845
siberex
pushed a commit
to siberex/bazel
that referenced
this pull request
Jul 4, 2019
Change-Id: I48ec300dd5eb2158ece0eea3e27098c45a5ca7be Closes bazelbuild#8566. Change-Id: I48ec300dd5eb2158ece0eea3e27098c45a5ca7be PiperOrigin-RevId: 252625845
irengrig
pushed a commit
to irengrig/bazel
that referenced
this pull request
Jul 15, 2019
Change-Id: I48ec300dd5eb2158ece0eea3e27098c45a5ca7be Closes bazelbuild#8566. Change-Id: I48ec300dd5eb2158ece0eea3e27098c45a5ca7be PiperOrigin-RevId: 252625845
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change-Id: I48ec300dd5eb2158ece0eea3e27098c45a5ca7be