Merged
Conversation
Member
|
Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (poco) have been updated in this PR. |
Contributor
Author
|
@bazel-io skip_check unstable_url |
Contributor
Author
|
@kotlaja PTAL |
kotlaja
approved these changes
Aug 19, 2025
Merged
bazel-io
pushed a commit
that referenced
this pull request
Aug 20, 2025
#5579 is not great, because some included symbols are not defined, leading to errors of the form ``` ld.lld: error: undefined symbol: Poco::floatToFixedStr(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>&, float, int, int, char, char) >>> referenced by NumberFormatter.cpp >>> bazel-out/haswell-fastbuild/bin/external/poco+/_objs/PocoFoundation/NumberFormatter.pic.o:(Poco::NumberFormatter::append(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>&, float, int, int)) ``` This might not be a problem when building with `-c opt`, depending on which parts of the library is used, as optimization flags will delete unused code. This fixes those issues (verified by building with `-c fastbuild`). Co-authored-by: Alex Faxå <alexanderfaxa@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I could not add an existing release because our build requires pocoproject/poco#4956 which is not yet included in a release. Thus, I used the option of adding a date tag and pinning to a commit, which seemed cleaner than adding that PR as a bunch of patch files.
This does not come with Windows or macOS support, which I have not bothered to add.