Skip to content

fix poco on BCR#5603

Merged
bazel-io merged 1 commit intobazelbuild:mainfrom
udaya2899:udaya2899/poco
Aug 20, 2025
Merged

fix poco on BCR#5603
bazel-io merged 1 commit intobazelbuild:mainfrom
udaya2899:udaya2899/poco

Conversation

@udaya2899
Copy link
Copy Markdown
Contributor

@udaya2899 udaya2899 commented Aug 20, 2025

#5579 is not great, because some included symbols are not defined, leading to errors of the form

ld.lld: error: undefined symbol: Poco::floatToFixedStr(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>&, float, int, int, char, char)
>>> referenced by NumberFormatter.cpp
>>>               bazel-out/haswell-fastbuild/bin/external/poco+/_objs/PocoFoundation/NumberFormatter.pic.o:(Poco::NumberFormatter::append(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>&, float, int, int))

This might not be a problem when building with -c opt, depending on which parts of the library is used, as optimization flags will delete unused code.

This fixes those issues (verified by building with -c fastbuild).

@udaya2899 @faximan
fix poco on BCR.
b130d64 
Co-authored-by: Alex Faxå <alexanderfaxa@google.com>
@bazel-io
Copy link
Copy Markdown
Member

bazel-io commented Aug 20, 2025

Hello @faximan, modules you maintain (poco) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

@faximan
Copy link
Copy Markdown
Contributor

faximan commented Aug 20, 2025

@bazel-io skip_check unstable_url

@bazel-io bazel-io added the skip-url-stability-check Skip the URL stability check for the PR label Aug 20, 2025
bazel-io
bazel-io approved these changes Aug 20, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bazelbuild/bcr-maintainers, all modules in this PR have been approved by their maintainers. This PR will be merged if all presubmit checks pass.

@bazel-io bazel-io merged commit 3bdf7fc into bazelbuild:main Aug 20, 2025
12 checks passed
@bazel-io bazel-io added the auto-merged This PR is automatically merged by the BCR reviewer bot. label Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bazel-io bazel-io bazel-io approved these changes

+1 more reviewer

@faximan faximan faximan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

auto-merged This PR is automatically merged by the BCR reviewer bot. skip-url-stability-check Skip the URL stability check for the PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@udaya2899 @bazel-io @faximan