Skip to content

rules_python@0.39.0, rules_python_gazelle_plugin@0.39.0#3171

Closed
publish-to-bcr-bot[bot] wants to merge 1 commit intobazelbuild:mainfrom
f0rmiga:bazelbuild/rules_python@0.39.0-e80f0866
Closed

rules_python@0.39.0, rules_python_gazelle_plugin@0.39.0#3171
publish-to-bcr-bot[bot] wants to merge 1 commit intobazelbuild:mainfrom
f0rmiga:bazelbuild/rules_python@0.39.0-e80f0866

Conversation

@publish-to-bcr-bot
Copy link
Copy Markdown
Contributor

@bazel-io
Copy link
Copy Markdown
Member

Hello @rickeylev, @f0rmiga, modules you maintain (rules_python, rules_python_gazelle_plugin) have been updated in this PR. Please review the changes.

@bazel-io
Copy link
Copy Markdown
Member

Hello @aignas, modules you maintain (rules_python) have been updated in this PR. Please review the changes.

Copy link
Copy Markdown
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bazelbuild/bcr-maintainers, all modules in this PR have been approved by their maintainers. Please take a final look to merge this PR.

@meteorcloudy
Copy link
Copy Markdown
Member

Can we drop Bazel 6 for Bzlmod support? Bazel 7 had tons of Bzlmod improvement (use_repo_rule), Bazel 6 still has Bzlmod disabled by default.

@meteorcloudy
Copy link
Copy Markdown
Member

And maybe add 8.0.0rc2 in the matrix to verify it works with Bazel 8?

@rickeylev
Copy link
Copy Markdown
Contributor

drop bazel 6, add bazel 8

Yes, we dropped bazel 6 bzlmod with this release. I have bazel-contrib/rules_python#2404 to fix that upstream.

I started #3180 to verify adding bazel 8.x to presubmit.yml actually works (It should 😅, but this is the first run of it under BCR).

So, you can force merge this (all the failures are Bazel 6, so fine to ignore), or un-draft 3180 and merge that instead (it's a copy of this, but with presubmit.yml changes).

@rickeylev
Copy link
Copy Markdown
Contributor

I've switched #3180 to non-draft.

Let's close this in favor of that one. It, at the least, has green presubmits.

@Wyverald Wyverald closed this Nov 13, 2024
fmeum pushed a commit that referenced this pull request Nov 14, 2024
BCR config for rules_python and rules_python_gazelle_plugin 0.39.0 

This is #3171,
but with
presubmit changes to remove Bazel 6 from the test matrix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants