Skip to content

rules_python@0.39.0, rules_python_gazelle_plugin@0.39.0#3180

Merged
fmeum merged 2 commits intobazelbuild:mainfrom
rickeylev:rules.python.39
Nov 14, 2024
Merged

rules_python@0.39.0, rules_python_gazelle_plugin@0.39.0#3180
fmeum merged 2 commits intobazelbuild:mainfrom
rickeylev:rules.python.39

Conversation

@rickeylev
Copy link
Copy Markdown
Contributor

@rickeylev rickeylev commented Nov 13, 2024

BCR config for rules_python and rules_python_gazelle_plugin 0.39.0

This is #3171, but with
presubmit changes to remove Bazel 6 from the test matrix.

@bazel-io
Copy link
Copy Markdown
Member

Hello @f0rmiga, modules you maintain (rules_python, rules_python_gazelle_plugin) have been updated in this PR. Please review the changes.

@bazel-io
Copy link
Copy Markdown
Member

Hello @aignas, modules you maintain (rules_python) have been updated in this PR. Please review the changes.

@rickeylev rickeylev marked this pull request as ready for review November 13, 2024 20:28
@rickeylev
Copy link
Copy Markdown
Contributor Author

Hrm. A couple of the tests are failing on Windows under Bazel 8, but are OK on Bazel 7. I suspect this is more to do with how those tests run things than a bug in the underlying code because all the other tests pass. https://buildkite.com/bazel/bcr-presubmit/builds/8816#01932730-8cf4-4510-a6f0-f74fba6c03e0

I'll have a look at this upstream. For now, I've removed the last_rc entry from the test matrix.

@rickeylev rickeylev changed the title (draft/wip) rules_python@0.39.0, rules_python_gazelle_plugin@0.39.0 rules_python@0.39.0, rules_python_gazelle_plugin@0.39.0 Nov 13, 2024
@rickeylev
Copy link
Copy Markdown
Contributor Author

Added mystery: Bazel 8 + Windows passes in rules_python's CI: https://buildkite.com/bazel/rules-python-python/builds/9639#01932741-201a-483b-b1ef-5551d108797e

The configs look almost identical: run bazel test ... in the examples/bzlmod directory. The only difference is BCR sets some additional copt flags, but I don't see why those would affect an output file being executable or not.

@rickeylev
Copy link
Copy Markdown
Contributor Author

Hm, a bit weird that the bot didn't come around and approve yet...after we approved.

@bazelbuild/bcr-maintainers just in case. It's ready to approve/merge.

@fmeum fmeum merged commit c307027 into bazelbuild:main Nov 14, 2024
@rickeylev rickeylev deleted the rules.python.39 branch November 14, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants