Allow --test_env / env= to override coverage env#29110
Closed
keith wants to merge 1 commit into
Closed
Conversation
Bazel sets some environment variables for CC coverage collection that can be useful to override in some projects. Previously this was possible but as a side effect of 87b0a1f it stopped working. This re-enables that and covers it in tests Fixes bazelbuild#23247
fmeum
approved these changes
Mar 26, 2026
gregestren
approved these changes
Mar 27, 2026
Member
Author
|
@bazel-io flag |
Member
|
@bazel-io fork 8.7.0 |
Member
|
@bazel-io fork 9.1.0 |
This was referenced Mar 31, 2026
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Mar 31, 2026
Bazel sets some environment variables for CC coverage collection that can be useful to override in some projects. Previously this was possible but as a side effect of 87b0a1f it stopped working. This re-enables that and covers it in tests Fixes bazelbuild#23247 Closes bazelbuild#29110. PiperOrigin-RevId: 892333567 Change-Id: If5dd77b1cc98390622276865ee80772fdbcb216c
iancha1992
pushed a commit
to iancha1992/bazel
that referenced
this pull request
Mar 31, 2026
Bazel sets some environment variables for CC coverage collection that can be useful to override in some projects. Previously this was possible but as a side effect of 87b0a1f it stopped working. This re-enables that and covers it in tests Fixes bazelbuild#23247 Closes bazelbuild#29110. PiperOrigin-RevId: 892333567 Change-Id: If5dd77b1cc98390622276865ee80772fdbcb216c
2 tasks
Member
|
@keith @fmeum @gregestren Do we actually need this in 8.7.0? |
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Mar 31, 2026
…9169) Bazel sets some environment variables for CC coverage collection that can be useful to override in some projects. Previously this was possible but as a side effect of 87b0a1f it stopped working. This re-enables that and covers it in tests Fixes #23247 Closes #29110. PiperOrigin-RevId: 892333567 Change-Id: If5dd77b1cc98390622276865ee80772fdbcb216c Commit 15e078b Co-authored-by: Keith Smiley <keithbsmiley@gmail.com>
Member
Author
|
@iancha1992 I think just 9.x is fine |
Member
Author
|
reopening #29167 |
keith
added a commit
to keith/bazel
that referenced
this pull request
Apr 23, 2026
…29110) Bazel sets some environment variables for CC coverage collection that can be useful to override in some projects. Previously this was possible but as a side effect of 87b0a1f it stopped working. This re-enables that and covers it in tests Fixes bazelbuild#23247 Closes bazelbuild#29110. Fixes bazelbuild#29167 PiperOrigin-RevId: 892333567 Change-Id: If5dd77b1cc98390622276865ee80772fdbcb216c (cherry picked from commit 15e078b)
iancha1992
pushed a commit
to iancha1992/bazel
that referenced
this pull request
May 4, 2026
…29383) Bazel sets some environment variables for CC coverage collection that can be useful to override in some projects. Previously this was possible but as a side effect of 87b0a1f it stopped working. This re-enables that and covers it in tests Fixes bazelbuild#23247 Closes bazelbuild#29110. Fixes bazelbuild#29167 PiperOrigin-RevId: 892333567 Change-Id: If5dd77b1cc98390622276865ee80772fdbcb216c (cherry picked from commit 15e078b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bazel sets some environment variables for CC coverage collection that
can be useful to override in some projects. Previously this was possible
but as a side effect of 87b0a1f it
stopped working. This re-enables that and covers it in tests
Fixes #23247