Skip to content

[8.7.0] Allow --test_env / env= to override coverage env#29383

Merged
iancha1992 merged 1 commit into
bazelbuild:release-8.7.0from
keith:ks/8.7.0-allow-test_env-env-to-override-coverage-env-https-github.com-bazelbuild-bazel-pull-29110
Apr 27, 2026
Merged

[8.7.0] Allow --test_env / env= to override coverage env#29383
iancha1992 merged 1 commit into
bazelbuild:release-8.7.0from
keith:ks/8.7.0-allow-test_env-env-to-override-coverage-env-https-github.com-bazelbuild-bazel-pull-29110

Conversation

@keith

@keith keith commented Apr 23, 2026

Copy link
Copy Markdown
Member

Bazel sets some environment variables for CC coverage collection that
can be useful to override in some projects. Previously this was possible
but as a side effect of 87b0a1f it
stopped working. This re-enables that and covers it in tests

Fixes #23247

Closes #29110.

Fixes #29167

PiperOrigin-RevId: 892333567
Change-Id: If5dd77b1cc98390622276865ee80772fdbcb216c
(cherry picked from commit 15e078b)

@keith keith changed the title [8.7.0] Allow --test_env / env= to override coverage env (https://github.com/bazelbuild/bazel/pull/29110) [8.7.0] Allow --test_env / env= to override coverage env Apr 23, 2026
@keith keith requested a review from iancha1992 April 23, 2026 16:58
@iancha1992 iancha1992 requested review from dabanki and gregestren and removed request for iancha1992 April 23, 2026 17:44
@iancha1992 iancha1992 added the team-Configurability platforms, toolchains, cquery, select(), config transitions label Apr 23, 2026
…29110)

Bazel sets some environment variables for CC coverage collection that
can be useful to override in some projects. Previously this was possible
but as a side effect of 87b0a1f it
stopped working. This re-enables that and covers it in tests

Fixes bazelbuild#23247

Closes bazelbuild#29110.

Fixes bazelbuild#29167

PiperOrigin-RevId: 892333567
Change-Id: If5dd77b1cc98390622276865ee80772fdbcb216c
(cherry picked from commit 15e078b)
@keith keith force-pushed the ks/8.7.0-allow-test_env-env-to-override-coverage-env-https-github.com-bazelbuild-bazel-pull-29110 branch from 22c7dad to ccfaf05 Compare April 23, 2026 23:44
@keith keith marked this pull request as ready for review April 24, 2026 00:33
@keith keith requested a review from a team as a code owner April 24, 2026 00:33
@github-actions github-actions Bot added the awaiting-review PR is awaiting review from an assigned reviewer label Apr 24, 2026
Comment thread src/test/shell/testenv.sh
}

# Returns 0 on macOS if an IPv6 default route is present according to netstat.
function has_ipv6_default_route() {

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this came from 695e7d5 but shouldn't be risky

@iancha1992 iancha1992 enabled auto-merge April 24, 2026 21:24
@iancha1992 iancha1992 added this pull request to the merge queue Apr 27, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 27, 2026
@iancha1992 iancha1992 added this pull request to the merge queue Apr 27, 2026
Merged via the queue into bazelbuild:release-8.7.0 with commit 2930633 Apr 27, 2026
47 checks passed
@github-actions github-actions Bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-Configurability platforms, toolchains, cquery, select(), config transitions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants