Fix crash when mixing use_repo_rule and --inject_repository
#27967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bazel crashes at HEAD when `use_repo_rule` is used with `local_repository` while also using `--inject_repository`. Make bugs like this less likely by extracting out a safe "get or create" helper for extension usages.
Collaborator
Author
|
@bazel-io fork 9.0.0 |
Collaborator
Author
|
@meteorcloudy This probably has to go out in an 8.5.1 release :-( |
There was a problem hiding this comment.
Code Review
This pull request addresses a crash that occurs when use_repo_rule and --inject_repository are used together for local_repository. The fix involves refactoring the creation of ModuleExtensionUsageBuilder into a centralized getOrCreateExtensionUsageBuilder helper method. This ensures that a single builder is used for the same non-isolated extension, preventing the duplication that caused the crash. The changes are logical, well-contained, and include a regression test to prevent this issue in the future. The code quality is improved by this refactoring.
Wyverald
approved these changes
Dec 13, 2025
|
@fmeum Could you please take a look at the failing checks? |
Collaborator
Author
|
@bharadwaj08-one That's an unrelated preexisting failure. @Wyverald |
Member
|
I'm already importing this. |
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Dec 15, 2025
Bazel crashes at HEAD when `use_repo_rule` is used with `local_repository` while also using `--inject_repository`. Make bugs like this less likely by extracting out a safe "get or create" helper for extension usages. Fixes bazelbuild#27953 Closes bazelbuild#27967. PiperOrigin-RevId: 844683022 Change-Id: I1edcf1e7c72ef8d46c67e51b4f9ffd6a6ce82ec8
Member
|
@iancha1992 Let's do a 8.5.1 |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 15, 2025
…y` (#27983) Bazel crashes at HEAD when `use_repo_rule` is used with `local_repository` while also using `--inject_repository`. Make bugs like this less likely by extracting out a safe "get or create" helper for extension usages. Fixes #27953 Closes #27967. PiperOrigin-RevId: 844683022 Change-Id: I1edcf1e7c72ef8d46c67e51b4f9ffd6a6ce82ec8 Commit 21d7fec Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
Member
|
@bazel-io fork 8.5.1 |
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Dec 15, 2025
Bazel crashes at HEAD when `use_repo_rule` is used with `local_repository` while also using `--inject_repository`. Make bugs like this less likely by extracting out a safe "get or create" helper for extension usages. Fixes bazelbuild#27953 Closes bazelbuild#27967. PiperOrigin-RevId: 844683022 Change-Id: I1edcf1e7c72ef8d46c67e51b4f9ffd6a6ce82ec8
Member
|
@bazel-io fork 8.6.0 |
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Dec 15, 2025
Bazel crashes at HEAD when `use_repo_rule` is used with `local_repository` while also using `--inject_repository`. Make bugs like this less likely by extracting out a safe "get or create" helper for extension usages. Fixes bazelbuild#27953 Closes bazelbuild#27967. PiperOrigin-RevId: 844683022 Change-Id: I1edcf1e7c72ef8d46c67e51b4f9ffd6a6ce82ec8
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 15, 2025
…y` (#27995) Bazel crashes at HEAD when `use_repo_rule` is used with `local_repository` while also using `--inject_repository`. Make bugs like this less likely by extracting out a safe "get or create" helper for extension usages. Fixes #27953 Closes #27967. PiperOrigin-RevId: 844683022 Change-Id: I1edcf1e7c72ef8d46c67e51b4f9ffd6a6ce82ec8 Commit 21d7fec Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 15, 2025
…y` (#27999) Bazel crashes at HEAD when `use_repo_rule` is used with `local_repository` while also using `--inject_repository`. Make bugs like this less likely by extracting out a safe "get or create" helper for extension usages. Fixes #27953 Closes #27967. PiperOrigin-RevId: 844683022 Change-Id: I1edcf1e7c72ef8d46c67e51b4f9ffd6a6ce82ec8 Commit 21d7fec Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bazel crashes at HEAD when
use_repo_ruleis used withlocal_repositorywhile also using--inject_repository.Make bugs like this less likely by extracting out a safe "get or create" helper for extension usages.
Fixes #27953