[8.6.0] Fix crash when mixing use_repo_rule and --inject_repository
#27999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bazel crashes at HEAD when `use_repo_rule` is used with `local_repository` while also using `--inject_repository`. Make bugs like this less likely by extracting out a safe "get or create" helper for extension usages. Fixes bazelbuild#27953 Closes bazelbuild#27967. PiperOrigin-RevId: 844683022 Change-Id: I1edcf1e7c72ef8d46c67e51b4f9ffd6a6ce82ec8
There was a problem hiding this comment.
Code Review
This pull request effectively resolves a crash that occurs when use_repo_rule is used with --inject_repository. The fix correctly identifies that duplicated logic for creating module extension usages was the root cause and introduces a centralized getOrCreateExtensionUsageBuilder helper method in ModuleThreadContext. This refactoring simplifies the code in ModuleFileFunction and ModuleFileGlobals, prevents the creation of duplicate extension builders, and improves overall maintainability. The addition of a regression test ensures this specific crash scenario is covered going forward. The changes are well-implemented and represent a solid improvement.
Wyverald
approved these changes
Dec 15, 2025
Merged
via the queue into
bazelbuild:release-8.6.0
with commit Dec 15, 2025
1c16fbf
47 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bazel crashes at HEAD when
use_repo_ruleis used withlocal_repositorywhile also using--inject_repository.Make bugs like this less likely by extracting out a safe "get or create" helper for extension usages.
Fixes #27953
Closes #27967.
PiperOrigin-RevId: 844683022
Change-Id: I1edcf1e7c72ef8d46c67e51b4f9ffd6a6ce82ec8
Commit 21d7fec