Skip to content

Move newCredentialHelperProvider into GoogleAuthUtils#15941

Closed
Yannic wants to merge 2 commits intobazelbuild:masterfrom
EngFlow:yannic-cr-mv-factory
Closed

Move newCredentialHelperProvider into GoogleAuthUtils#15941
Yannic wants to merge 2 commits intobazelbuild:masterfrom
EngFlow:yannic-cr-mv-factory

Conversation

@Yannic
Copy link
Copy Markdown
Contributor

@Yannic Yannic commented Jul 21, 2022

Follow-up on #15930 due to
#15906

Progress on #15856

@Yannic Yannic marked this pull request as ready for review July 21, 2022 17:13
@Yannic Yannic requested a review from a team as a code owner July 21, 2022 17:13
@Yannic
Copy link
Copy Markdown
Contributor Author

Yannic commented Jul 21, 2022

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Jul 21, 2022
@Yannic
Copy link
Copy Markdown
Contributor Author

Yannic commented Jul 21, 2022

@tjgq PTAL

@sgowroji
Copy link
Copy Markdown
Member

sgowroji commented Jul 22, 2022

@bazel-io fork 5.3.0

@bazel-io bazel-io mentioned this pull request Jul 22, 2022
Closed
@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Jul 22, 2022
@sgowroji sgowroji added the team-Remote-Exec Issues and PRs for the Execution (Remote) team label Jul 22, 2022
sgowroji pushed a commit to sgowroji/bazel that referenced this pull request Jul 22, 2022
@Yannic
Move newCredentialHelperProvider into GoogleAuthUtils
5e7351b 
Follow-up on bazelbuild#15930 due to
bazelbuild#15906

Progress on bazelbuild#15856

Closes bazelbuild#15941.

PiperOrigin-RevId: 462580799
Change-Id: Ibac79ed68a0c87a4f34eb9d0729abb1552b44519
@sgowroji sgowroji mentioned this pull request Jul 22, 2022
Closed
@ShreeM01 ShreeM01 mentioned this pull request Jul 25, 2022
Merged
ckolli5 added a commit that referenced this pull request Jul 25, 2022
@ShreeM01 @Yannic @ckolli5
Move newCredentialHelperProvider into GoogleAuthUtils (#15973)
508f185 
Follow-up on #15930 due to
#15906

Progress on #15856

Closes #15941.

PiperOrigin-RevId: 462580799
Change-Id: Ibac79ed68a0c87a4f34eb9d0729abb1552b44519

Co-authored-by: Yannic Bonenberger <yannic@engflow.com>
Co-authored-by: Chenchu K <ckolli@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tjgq tjgq tjgq approved these changes

Assignees

No one assigned

Labels

team-Remote-Exec Issues and PRs for the Execution (Remote) team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Yannic @sgowroji @tjgq @bazel-io