Add netrc support to --bes_backend#15930
Closed
Yannic wants to merge 7 commits intobazelbuild:masterfrom
Closed
Conversation
Contributor
Author
|
@bazel-io flag |
Contributor
Author
|
@tjgq PTAL |
tjgq
requested changes
Jul 20, 2022
src/main/java/com/google/devtools/build/lib/authandtls/GoogleAuthUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/authandtls/GoogleAuthUtils.java
Outdated
Show resolved
Hide resolved
| @@ -191,7 +197,21 @@ private static NettyChannelBuilder newNettyChannelBuilder(String targetUrl, Stri | |||
| * @throws IOException in case the call credentials can't be constructed. | |||
| */ | |||
| @Nullable | |||
Contributor
There was a problem hiding this comment.
Copy the comment from newCallCredentials here, to make it clear where we attempt to retrieve credentials from.
Contributor
Author
There was a problem hiding this comment.
Found a simple way to delete the method instead.
src/main/java/com/google/devtools/build/lib/authandtls/GoogleAuthUtils.java
Outdated
Show resolved
Hide resolved
Member
|
@bazel-io fork 5.3.0 |
tjgq
requested changes
Jul 20, 2022
Contributor
tjgq
left a comment
There was a problem hiding this comment.
Looks like //src/test/java/com/google/devtools/build/lib/buildeventservice:BazelBuildEventServiceModuleTest needs fixing?
Contributor
Author
|
Fixed, PTAL |
tjgq
approved these changes
Jul 21, 2022
Contributor
|
FYI, I'll have to remove a couple of |
Yannic
added a commit
to EngFlow/bazel
that referenced
this pull request
Jul 21, 2022
Follow-up on bazelbuild#15930 due to bazelbuild#15906 Progress on bazelbuild#15856
sgowroji
pushed a commit
to sgowroji/bazel
that referenced
this pull request
Jul 22, 2022
Follow-up on bazelbuild#15930 due to bazelbuild#15906 Progress on bazelbuild#15856 Closes bazelbuild#15941. PiperOrigin-RevId: 462580799 Change-Id: Ibac79ed68a0c87a4f34eb9d0729abb1552b44519
ckolli5
pushed a commit
to ckolli5/bazel
that referenced
this pull request
Jul 22, 2022
Progress on bazelbuild#15856 Fixes bazelbuild#15928 Closes bazelbuild#15930. PiperOrigin-RevId: 462379746 Change-Id: Ia7ae470bdcbd97c6cb42cc290c3891393ec9ce3a
tjgq
pushed a commit
to tjgq/bazel
that referenced
this pull request
Jul 25, 2022
Progress on bazelbuild#15856 Fixes bazelbuild#15928 Closes bazelbuild#15930. PiperOrigin-RevId: 462379746 Change-Id: Ia7ae470bdcbd97c6cb42cc290c3891393ec9ce3a
ckolli5
pushed a commit
that referenced
this pull request
Jul 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Progress on #15856
Fixes #15928