pip: 20.3.4 -> 21.0.1#412
Merged
thundergolfer merged 9 commits intobazel-contrib:masterfrom Mar 30, 2021
Merged
Conversation
Collaborator
Author
|
Build failure is due to CI running Python3.5 which is EOL. pip 21.x dropped support for all Python 2 and Python 3.5. |
bbb2933 to
b12e6e8
Compare
13 tasks
11 tasks
thundergolfer
approved these changes
Mar 30, 2021
1 task
1 task
This was referenced Apr 12, 2021
1 task
1 task
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: No urgency to rush this. It introduces a breaking change where pip_install will only work for Python3+. If any release of rules_python needs to be done prior to prepare a final Python2 compatible release, it should be done before merging this.
PR Checklist
Please check if your PR fulfills the following requirements:
.parfiles. See CONTRIBUTING.md for infoPR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Follow up to #405
This PR introduces pip 21.0.1 as the vendored version of pip. This version of pip will only support Python 3+ and is pip breaking away from Python 2 support since pip 21.0: https://pip.pypa.io/en/stable/news/#id1
My suggestion would be to first merge #405 and prepare a release or tag along with documentation around the
pip_installPython 2 support. Then this PR can be rebased against upstream bazelbuild/rules_python and merged to support Python 3pip_jnstallsupport only for future development.Does this PR introduce a breaking change?
Other information
PR Checklist
Please check if your PR fulfills the following requirements:
.parfiles. See CONTRIBUTING.md for infoPR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Follow up to #405
This PR introduces pip 21.0.1 as the vendored version of pip. This version of pip will only support Python 3+ and is pip breaking away from Python 2 support since pip 21.0: https://pip.pypa.io/en/stable/news/#id1
My suggestion would be to first merge #405 and prepare a release or tag along with documentation around the
pip_installPython 2 support. Then this PR can be rebased against upstream bazelbuild/rules_python and merged to support Python 3pip_jnstallsupport only for future development.Does this PR introduce a breaking change?
Python3 only support for
pip_installdue to pip upgrade.