Merged
Conversation
13 tasks
hrfuller
approved these changes
Feb 2, 2021
Contributor
hrfuller
left a comment
There was a problem hiding this comment.
I agree with your suggestion of tagging a new version indicating this is the last version that supports python2 out of the box, but users will always be able to override these deps to use older versions of pip with pip_install if they would like. Not sure how we can force python3 on all our users given they can override the python_interpreter attr in pip_install anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
.parfiles. See CONTRIBUTING.md for infoPR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Updates the vendored version of pip from 20.3.3 to 20.3.4.
Notably, this is slated to be the last version of pip that will support Python 2.
pypa/pip#8936 (comment)
It might be prudent to prepare and tag a release of rules_python if this is merged.
I would also suggest that rules_python, at least from the
pip_installperspective, should target Python 3 only and mention this in the README files. I understand that the Bazel rules_python, in general, will need to support Python 2 until this requirement is removed from Bazel itself (and perhaps internally at Google), but thepip_installelements of the rules need not support Python 2 in my opinion. It is EOL and further developments in Python packaging are not going to support Python 2 (or Python <3.5) so it might be time to start enforcing this too.Note, there is an additional PR here with pip 21.0 that can be merged after this one. Which I would then consider a clean breaking change for the Python 2 vs Python 3 support for rules_python
pip_install. In the same way that pip supports Python 2 withpip<21it would be possible to point users at a commit or version of rules_pythonpip_installthat does work with Python 2 if they need it.I suspect my recommendation is overly cautious, I suspect the number of users that are using rules_python (for external pip dependencies) and Python 2 to be 0 or vanishingly close to 0.
Does this PR introduce a breaking change?
This PR would not be introducing a breaking change, the breaking change is in the follow-up PR that introduces pip 21.0
Other information