fix: escape more invalid repo string characters#2801
Merged
rickeylev merged 2 commits intobazel-contrib:mainfrom Apr 22, 2025
Merged
Conversation
4df87bc to
2653573
Compare
Collaborator
|
Thanks! |
aignas
approved these changes
Apr 22, 2025
aignas
added a commit
to aignas/rules_python
that referenced
this pull request
Apr 22, 2025
In addition to bazel-contrib#2801 I wanted to ensure that we are getting the correct filename when downloading wheels. It seems that the `%` in the wheel filename might get through wheels that get referenced via direct URL in the requirements.txt files.
aignas
pushed a commit
that referenced
this pull request
Apr 22, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 22, 2025
In addition to #2801 I wanted to ensure that we are getting the correct filename when downloading wheels. It seems that the `%` in the wheel filename might get through wheels that get referenced via direct URL in the requirements.txt files. --------- Co-authored-by: Richard Levasseur <richardlev@gmail.com> Co-authored-by: Richard Levasseur <rlevasseur@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also escape plus and percent when generating the repo name from the wheel version.
Sometimes they have such characters in them.
Fixes #2799