test(pypi): add a test case for simpleapi html parsing with %#2811
Merged
rickeylev merged 3 commits intobazel-contrib:mainfrom Apr 22, 2025
Merged
test(pypi): add a test case for simpleapi html parsing with %#2811rickeylev merged 3 commits intobazel-contrib:mainfrom
rickeylev merged 3 commits intobazel-contrib:mainfrom
Conversation
In addition to bazel-contrib#2801 I wanted to ensure that we are getting the correct filename when downloading wheels. It seems that the `%` in the wheel filename might get through wheels that get referenced via direct URL in the requirements.txt files.
rickeylev
approved these changes
Apr 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition to #2801 I wanted to ensure that we are getting the correct
filename when downloading wheels. It seems that the
%in the wheelfilename might get through wheels that get referenced via direct URL in
the requirements.txt files.