fix: Handle the empty whl_map correctly#1623
Closed
kshramt wants to merge 1 commit intobazel-contrib:mainfrom
Closed
fix: Handle the empty whl_map correctly#1623kshramt wants to merge 1 commit intobazel-contrib:mainfrom
whl_map correctly#1623kshramt wants to merge 1 commit intobazel-contrib:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
rickeylev
requested changes
Dec 17, 2023
Collaborator
rickeylev
left a comment
There was a problem hiding this comment.
Ah, it looks like the bug is bzl_packages can be None, which then the for-loop tries to iterate over? Thanks for finding this.
Can you update the description to describe the bug and fix, please? A test can be added to tests/pip_hub_repository/render_pkg_aliases/render_pkg_aliases_test.bzl
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 24, 2024
With this change we handle correctly the case where the requirements.txt might be empty (e.g. during onboarding to `rules_python`). I have added an integration test because this usecase seems important enough to be covered to ensure that we have no regressions. It also creates a place to add more `pip.parse` and `pip_parse` tests. Closes #1623.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.