fix(bzlmod): do not fail pip.parse with empty requirements.txt#1718
Merged
aignas merged 6 commits intobazel-contrib:mainfrom Jan 24, 2024
Merged
fix(bzlmod): do not fail pip.parse with empty requirements.txt#1718aignas merged 6 commits intobazel-contrib:mainfrom
aignas merged 6 commits intobazel-contrib:mainfrom
Conversation
rickeylev
approved these changes
Jan 24, 2024
Collaborator
rickeylev
left a comment
There was a problem hiding this comment.
just some small nits, otherwise lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change we handle correctly the case where the requirements.txt
might be empty (e.g. during onboarding to
rules_python). I have addedan integration test because this usecase seems important enough to be covered
to ensure that we have no regressions. It also creates a place to add more
pip.parseandpip_parsetests.Closes #1623.