Skip to content

go: use "shell" params file format instead of "multiline"#2655

Merged
jayconrod merged 2 commits intobazel-contrib:masterfrom
jayconrod:fix-conflict-params
Sep 21, 2020
Merged

go: use "shell" params file format instead of "multiline"#2655
jayconrod merged 2 commits intobazel-contrib:masterfrom
jayconrod:fix-conflict-params

Conversation

@jayconrod
Copy link
Copy Markdown
Collaborator

This lets arguments contain newlines.

Fixes #2635

@jayconrod jayconrod merged commit b4c392f into bazel-contrib:master Sep 21, 2020
@jayconrod jayconrod deleted the fix-conflict-params branch September 21, 2020 21:01
jayconrod pushed a commit that referenced this pull request Sep 22, 2020
This lets arguments contain newlines.

Fixes #2635
jayconrod pushed a commit that referenced this pull request Sep 22, 2020
This lets arguments contain newlines.

Fixes #2635
jayconrod pushed a commit that referenced this pull request Sep 22, 2020
This lets arguments contain newlines.

Fixes #2635
yushan26 pushed a commit to yushan26/rules_go that referenced this pull request Jun 16, 2025
…-contrib#2655)

This PR adds support for installing wheels via direct urls in the
requirements lock file:
```
foo==0.0.1 @ https://someurl.org/package.whl
bar==0.0.1 @ https://someurl.org/package.tar.gz
```
This is to improve parity between bazel downloader and pip behavior.
Before this change, direct urls used fallback to pip install.

Partially addresses bazel-contrib#2363 as it does not add support for git urls.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

go: encode newlines in package conflict messages passed to builder

2 participants