Skip to content

Announce Gazelle v0.20.0 [skip ci]#2363

Merged
jayconrod merged 1 commit intobazel-contrib:masterfrom
jayconrod:update-boilerplate
Feb 6, 2020
Merged

Announce Gazelle v0.20.0 [skip ci]#2363
jayconrod merged 1 commit intobazel-contrib:masterfrom
jayconrod:update-boilerplate

Conversation

@jayconrod
Copy link
Copy Markdown
Collaborator

No description provided.

@jayconrod jayconrod requested a review from ianthehat as a code owner February 6, 2020 18:29
@jayconrod jayconrod merged commit 9c9136c into bazel-contrib:master Feb 6, 2020
@jayconrod jayconrod deleted the update-boilerplate branch February 6, 2020 18:30
yushan26 pushed a commit to yushan26/rules_go that referenced this pull request Jun 16, 2025
…-contrib#2655)

This PR adds support for installing wheels via direct urls in the
requirements lock file:
```
foo==0.0.1 @ https://someurl.org/package.whl
bar==0.0.1 @ https://someurl.org/package.tar.gz
```
This is to improve parity between bazel downloader and pip behavior.
Before this change, direct urls used fallback to pip install.

Partially addresses bazel-contrib#2363 as it does not add support for git urls.
yushan26 pushed a commit to yushan26/rules_go that referenced this pull request Jun 16, 2025
…ied (bazel-contrib#2695)

This pull request modifies the SimpleAPI HTML parsing to add a new
field where we can get the `sha256` values by package version. This
allows us to very easily fallback to all packages of a particular
version when using `experimental_index_url` if the hashes are not
specified.

The code deciding which packages to query the SimpleAPI for has been
also modified to only omit queries for packages that are included via
direct URL references.

If we fail to get the data from the SimpleAPI, we will fallback to
`pip` and try to install it via the legacy behaviour.

Fixes bazel-contrib#2023
Work towards bazel-contrib#260
Work towards bazel-contrib#1357
Work towards bazel-contrib#2363

---------

Co-authored-by: Ignas Anikevicius <240938+aignas@users.noreply.github.com>
yushan26 pushed a commit to yushan26/rules_go that referenced this pull request Jun 16, 2025
…ib#2732)

Whilst integrating bazel-contrib#2695 I introduced a regression and here I add a test
for that and fix it. The code that was getting the filename from the URL
was too eager and would break if there was a git ref as noted in the
test.

Before this commit and bazel-contrib#2695 the code was not handling all of the cases
that are tested now either, so I think now we are in a good place. I am
not sure how we should handle the `git_repository` URLs. Maybe having
`http_archive` and `git_repository` usage would be nice, but I am not
sure
how we can introduce it at the moment.

Work towards bazel-contrib#2363
yushan26 pushed a commit to yushan26/rules_go that referenced this pull request Jun 16, 2025
…ntrib#2843)

Summary:
- Better handle git references for sdists.
- Better handle direct whl references.
- Add an extra test that turned out to be not needed in the end, but I
  left it to increase the code coverage.

Work towards bazel-contrib#2363
Fixes bazel-contrib#2828
yushan26 pushed a commit to yushan26/rules_go that referenced this pull request Jun 16, 2025
…ust (bazel-contrib#2871)

Summary:
- Make the requirement line the same as the one that is used in whls. It
  only contains extras and the version if it is present.
- Add debug log statements if we fail to get the version from a direct
  URL reference.
- Move some tests from `parse_requirements_tests` to
  `index_sources_tests` to improve test
  maintenance.
- Replace the URL encoded `+` to a regular `+` in the filename.
- Correctly handle the case when the `=sha256:` is used in the URL.

Once this is merged I plan to tackle bazel-contrib#2648 by changing the
`parse_requirements` code to de-duplicate entries returned
by the `parse_requirements` function.

I cannot think of anything else that we can do for this as of now, so
will mark the associated issue as resolved.

Fixes bazel-contrib#2363
Work towards bazel-contrib#2648
yushan26 pushed a commit to yushan26/rules_go that referenced this pull request Jun 16, 2025
When given .whl file URLs and no file name, `whl_library` writes the
wheel it downloads to a file with the same file name as the first URL's.
But then at extraction time, it always consults ctx.attr.filename
for that file name, leading to failure when that attribute is None.
This patch should fix that.

Related bazel-contrib#2363
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants