Skip to content

De-duplicate coverdata for link action#2152

Merged
jayconrod merged 1 commit intobazel-contrib:masterfrom
jayconrod:dedup-coverdata
Jul 19, 2019
Merged

De-duplicate coverdata for link action#2152
jayconrod merged 1 commit intobazel-contrib:masterfrom
jayconrod:dedup-coverdata

Conversation

@jayconrod
Copy link
Copy Markdown
Collaborator

Fixes #2151

@jayconrod jayconrod requested a review from ianthehat as a code owner July 19, 2019 17:21
@jayconrod jayconrod merged commit 6982949 into bazel-contrib:master Jul 19, 2019
@jayconrod jayconrod deleted the dedup-coverdata branch July 19, 2019 18:57
jayconrod pushed a commit that referenced this pull request Jul 19, 2019
yushan26 pushed a commit to yushan26/rules_go that referenced this pull request Jun 16, 2025
…when build sdist (bazel-contrib#2126)

Building sdist results in `Could not find a version that satisfies the
requirement setuptool` this regressed when a fix in parameter handling
got introduced in bazel-contrib#2091.

Before this change the building from sdist when using
`experimental_index_url`
would break because `--no-index` is passed to `pip`. This means that
`pip`
would fail to locate build time dependencies needed for the packages and
would
just not work. In `whl_library` we setup `PYTHONPATH` to have some build
dependencies available (like `setuptools`) and we could use them during
building from `sdist` and to do so we need to add `--no-build-isolation`
flag.
However, for some cases we need to also add other build-time
dependencies (e.g.
`flit_core`) so that the building of the wheel in the `repository_rule`
context
is successfuly. Removing `--no-index` allows `pip` to silently fetch the
needed
build dependencies from PyPI if they are missing and continue with the
build.

This is not a perfect solution, but it does unblock users to use the
`sdist`
distributions with the experimental feature enabled by using
`experimental_index_url` (see bazel-contrib#260 for tracking of the completion).

Fixes bazel-contrib#2118
Fixes bazel-contrib#2152

---------

Co-authored-by: aignas <240938+aignas@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

duplicate dep on coverdata

2 participants