Skip to content

Update dependencies#2126

Merged
jayconrod merged 2 commits intobazel-contrib:masterfrom
jayconrod:update-dependencies
Jul 10, 2019
Merged

Update dependencies#2126
jayconrod merged 2 commits intobazel-contrib:masterfrom
jayconrod:update-dependencies

Conversation

@jayconrod
Copy link
Copy Markdown
Collaborator

  • com_google_protobuf is removed because we can't call its macro from
    go_rules_dependencies.
  • org_golang_google_grpc and its dependencies are removed because
    there are too many of them.
  • Rewrote go/workspace.rst documentation.

Fixes #2113

* com_google_protobuf is removed because we can't call its macro from
  go_rules_dependencies.
* org_golang_google_grpc and its dependencies are removed because
  there are too many of them.
* Rewrote go/workspace.rst documentation.

Fixes bazel-contrib#2113
@jayconrod jayconrod requested a review from ianthehat as a code owner July 9, 2019 22:06
@linzhp
Copy link
Copy Markdown
Contributor

linzhp commented Jul 9, 2019

Thanks for doing this. We need the newer version of x/tools from different tasks

@jayconrod jayconrod merged commit 4a42b40 into bazel-contrib:master Jul 10, 2019
@jayconrod jayconrod deleted the update-dependencies branch July 10, 2019 20:14
yushan26 pushed a commit to yushan26/rules_go that referenced this pull request Jun 16, 2025
…when build sdist (bazel-contrib#2126)

Building sdist results in `Could not find a version that satisfies the
requirement setuptool` this regressed when a fix in parameter handling
got introduced in bazel-contrib#2091.

Before this change the building from sdist when using
`experimental_index_url`
would break because `--no-index` is passed to `pip`. This means that
`pip`
would fail to locate build time dependencies needed for the packages and
would
just not work. In `whl_library` we setup `PYTHONPATH` to have some build
dependencies available (like `setuptools`) and we could use them during
building from `sdist` and to do so we need to add `--no-build-isolation`
flag.
However, for some cases we need to also add other build-time
dependencies (e.g.
`flit_core`) so that the building of the wheel in the `repository_rule`
context
is successfuly. Removing `--no-index` allows `pip` to silently fetch the
needed
build dependencies from PyPI if they are missing and continue with the
build.

This is not a perfect solution, but it does unblock users to use the
`sdist`
distributions with the experimental feature enabled by using
`experimental_index_url` (see bazel-contrib#260 for tracking of the completion).

Fixes bazel-contrib#2118
Fixes bazel-contrib#2152

---------

Co-authored-by: aignas <240938+aignas@users.noreply.github.com>
yushan26 pushed a commit to yushan26/rules_go that referenced this pull request Jun 16, 2025
…rib#2360)

Fixes bazel-contrib#2328.

In bazel-contrib#2126, we discussed and added `--no-build-isolation` to ensure that
sdist builds pulled from rules_python supplied dependencies. An
unanticipated/misunderstood side-effect of this is that pip will no
longer resolve necessary, declared build time dependencies from a
package index. That's a significant point of friction for users, and,
it's much harder to opt-out of the behavior than to opt-in given the
presence of `extra_pip_args`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

org_golang_x_tools is almost 4 months old

3 participants