CI: upgrade rules_go for BCR tests#2237
Merged
jayconrod merged 2 commits intobazel-contrib:masterfrom Nov 18, 2025
Merged
Conversation
Bazel 9.x requires the cc_common module to be loaded explicitly. bazel-contrib/rules_go#4508 added the required load statement, and this fix was released in rules_go 0.59.0. This change upgrades the tests/bcr/go_mod and go_work test modules to require rules_go 0.59.0 so they can be tested with Bazel 9.x. Gazelle itself doesn't require the fix, so this change doesn't touch MODULE.bazel, avoiding a forced upgrade. Fixes bazel-contrib#2234
fmeum
approved these changes
Nov 18, 2025
Member
|
Looks like we need to get a new version of circl into the BCR that has loads for rules_cc. |
Contributor
Author
|
Hmm, upgrading circl fixed the problem: the next point release has correct loads. But the latest BCR release is pretty far behind the latest upstream release. That's a separate problem I suppose. |
pcj
pushed a commit
to stackb/bazel-gazelle
that referenced
this pull request
Dec 23, 2025
**What type of PR is this?** > Bug fix **What package or component does this PR mostly affect?** tests/bcr **What does this PR do? Why is it needed?** Bazel 9.x requires the cc_common module to be loaded explicitly. bazel-contrib/rules_go#4508 added the required load statement, and this fix was released in rules_go 0.59.0. This change upgrades the tests/bcr/go_mod and go_work test modules to require rules_go 0.59.0 so they can be tested with Bazel 9.x. Gazelle itself doesn't require the fix, so this change doesn't touch MODULE.bazel, avoiding a forced upgrade. **Which issues(s) does this PR fix?** Fixes bazel-contrib#2234 **Other notes for review**
Closed
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What package or component does this PR mostly affect?
tests/bcr
What does this PR do? Why is it needed?
Bazel 9.x requires the cc_common module to be loaded explicitly. bazel-contrib/rules_go#4508 added the required load statement, and this fix was released in rules_go 0.59.0.
This change upgrades the tests/bcr/go_mod and go_work test modules to require rules_go 0.59.0 so they can be tested with Bazel 9.x. Gazelle itself doesn't require the fix, so this change doesn't touch MODULE.bazel, avoiding a forced upgrade.
Which issues(s) does this PR fix?
Fixes #2234
Other notes for review