Conversation
There was a problem hiding this comment.
For better readability it may be useful to introduce a factory method:
Cell.create()
And maybe move all the magic inside it
There was a problem hiding this comment.
Agreed. That is a pretty verbose line already.
There was a problem hiding this comment.
But then our Cell knows about every network protocol implementation.
There was a problem hiding this comment.
You are totally right about this case, but at the moment, since we have the only one protocol from my point of view it's better to introduce template method. Later, if that become a case, we may do simple refactoring to introduce AbstractFactory with PBCellConcreteFactory and WhateEverProtoConcreteFactory..
if we are going to move magic inside the factory method, better to call the method kinda fromPB(..)
There was a problem hiding this comment.
To reduce memory consumption, since it is stateless and without polymorphic behavior, better to use as a kind of static facade.
There was a problem hiding this comment.
it's better to instantiate knownParams here, since we know exact size
Rename & split ImmutablePbResultFactory into PbResultFactory and CollectionConverters. IntelliJ Reformat, & cleanup.
…-creation Simplify Riak cluster creation HostAndPort was added
Ready: TS List Keys + Lite/Immutable TS data classes.
…perations were changed to use Iterable.
|
+1 after my last cleanup a6e48fb |
Finally ready. Contains all the new classes/commands/operations for the new TS API.
Also contains some general code formatting cleanup, as well as removing support for Java 6.