Simplify Riak cluster creation HostAndPort was added#577
Merged
alexmoore merged 5 commits intotimeseriesfrom Dec 8, 2015
Merged
Simplify Riak cluster creation HostAndPort was added#577alexmoore merged 5 commits intotimeseriesfrom
alexmoore merged 5 commits intotimeseriesfrom
Conversation
40cbc7f to
72a913c
Compare
Contributor
There was a problem hiding this comment.
Let's move the brackets to the next line style here.
if (blah)
{...
Contributor
|
Looks mostly good, just need to fix the formatting of the brackets to match the project. +0.75 otherwise. |
Contributor
Author
|
@alexmoore I also realized that introduced approach should be propagated to the RiakClient level as a newClient() routine.. Will add it and adjust PR according your comments. |
alexmoore
added a commit
that referenced
this pull request
Dec 8, 2015
…-creation Simplify Riak cluster creation HostAndPort was added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.