fix: use u64 for reverted_gas_used in execute_best_transactions#756
Closed
letmehateu wants to merge 1 commit intobase:mainfrom
Closed
fix: use u64 for reverted_gas_used in execute_best_transactions#756letmehateu wants to merge 1 commit intobase:mainfrom
letmehateu wants to merge 1 commit intobase:mainfrom
Conversation
Collaborator
✅ Heimdall Review Status
|
refcell
approved these changes
Feb 24, 2026
Contributor
refcell
left a comment
There was a problem hiding this comment.
Fine including this change
Contributor
|
I'm gonna close this for now -- not super critical and there's too many changes going on at the moment. Please feel free to re-open a new PR with the fixes. |
mw2000
pushed a commit
that referenced
this pull request
Mar 7, 2026
* feat: backup fp cache * docs: update proposer.md * test: unit and integration backup tests * fix: dedicated blocking thread pool * fix: test_proposer_backup_persistence * test: add recovery test with backup * fix: rebasing issue * nit: touchups * chore: rename to BACKUP_PATH * chore: address comments (#763) * chore(fault-proof): add comment explaining non-persisted backup fields * fix(fault-proof): use tempfile for atomic backup writes * fix(fault-proof): validate backup path at startup * feat(fault-proof): add backup metrics for observability * refactor(fault-proof): improve backup path validation and restore logic Consolidate duplicate if-let blocks, add tracing for restore operations, handle empty parent path edge case for relative paths, and log cleanup failures. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * test(fault-proof): add schema guard test for backup version Add a test that fails if Game or ProposerBackup fields change, reminding developers to bump BACKUP_VERSION when schema changes. This catches accidental schema changes that would break backup compatibility. * refactor(fault-proof): simplify backup restore logic Remove redundant path.exists() check before try_restore. Now only logs error metric when file exists but couldn't be parsed, avoiding double filesystem access and correctly distinguishing missing file from corrupt. * refactor(fault-proof): use tempfile for backup path write test Replace manual File::create + remove_file with NamedTempFile for the write permission check. Ensures cleanup on panic and is consistent with the atomic write approach used in backup.rs. --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> * refactor(fault-proof): remove duplicate backup restore log The log in ProposerState::try_restore() already provides restore information with game count and cursor details. * fix(tests): update optimism submodule for backup support The submodule was reverted to an older commit during a merge with main. This restores the correct commit that includes WithFPBackupPath needed by the faultproof test presets. * fix(tests): update optimism submodule to merged backup+challenger Updates tests/optimism to 32bd7c930 which includes PR #325 merge of backup support into op-succinct-sysgo branch. --------- Co-authored-by: Taehoon Kim <taehoon@succinct.xyz> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
mw2000
pushed a commit
that referenced
this pull request
Mar 9, 2026
* feat: backup fp cache * docs: update proposer.md * test: unit and integration backup tests * fix: dedicated blocking thread pool * fix: test_proposer_backup_persistence * test: add recovery test with backup * fix: rebasing issue * nit: touchups * chore: rename to BACKUP_PATH * chore: address comments (#763) * chore(fault-proof): add comment explaining non-persisted backup fields * fix(fault-proof): use tempfile for atomic backup writes * fix(fault-proof): validate backup path at startup * feat(fault-proof): add backup metrics for observability * refactor(fault-proof): improve backup path validation and restore logic Consolidate duplicate if-let blocks, add tracing for restore operations, handle empty parent path edge case for relative paths, and log cleanup failures. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * test(fault-proof): add schema guard test for backup version Add a test that fails if Game or ProposerBackup fields change, reminding developers to bump BACKUP_VERSION when schema changes. This catches accidental schema changes that would break backup compatibility. * refactor(fault-proof): simplify backup restore logic Remove redundant path.exists() check before try_restore. Now only logs error metric when file exists but couldn't be parsed, avoiding double filesystem access and correctly distinguishing missing file from corrupt. * refactor(fault-proof): use tempfile for backup path write test Replace manual File::create + remove_file with NamedTempFile for the write permission check. Ensures cleanup on panic and is consistent with the atomic write approach used in backup.rs. --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> * refactor(fault-proof): remove duplicate backup restore log The log in ProposerState::try_restore() already provides restore information with game count and cursor details. * fix(tests): update optimism submodule for backup support The submodule was reverted to an older commit during a merge with main. This restores the correct commit that includes WithFPBackupPath needed by the faultproof test presets. * fix(tests): update optimism submodule to merged backup+challenger Updates tests/optimism to 32bd7c930 which includes PR #325 merge of backup support into op-succinct-sysgo branch. --------- Co-authored-by: Taehoon Kim <taehoon@succinct.xyz> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
mw2000
pushed a commit
that referenced
this pull request
Mar 16, 2026
* feat: backup fp cache * docs: update proposer.md * test: unit and integration backup tests * fix: dedicated blocking thread pool * fix: test_proposer_backup_persistence * test: add recovery test with backup * fix: rebasing issue * nit: touchups * chore: rename to BACKUP_PATH * chore: address comments (#763) * chore(fault-proof): add comment explaining non-persisted backup fields * fix(fault-proof): use tempfile for atomic backup writes * fix(fault-proof): validate backup path at startup * feat(fault-proof): add backup metrics for observability * refactor(fault-proof): improve backup path validation and restore logic Consolidate duplicate if-let blocks, add tracing for restore operations, handle empty parent path edge case for relative paths, and log cleanup failures. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * test(fault-proof): add schema guard test for backup version Add a test that fails if Game or ProposerBackup fields change, reminding developers to bump BACKUP_VERSION when schema changes. This catches accidental schema changes that would break backup compatibility. * refactor(fault-proof): simplify backup restore logic Remove redundant path.exists() check before try_restore. Now only logs error metric when file exists but couldn't be parsed, avoiding double filesystem access and correctly distinguishing missing file from corrupt. * refactor(fault-proof): use tempfile for backup path write test Replace manual File::create + remove_file with NamedTempFile for the write permission check. Ensures cleanup on panic and is consistent with the atomic write approach used in backup.rs. --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> * refactor(fault-proof): remove duplicate backup restore log The log in ProposerState::try_restore() already provides restore information with game count and cursor details. * fix(tests): update optimism submodule for backup support The submodule was reverted to an older commit during a merge with main. This restores the correct commit that includes WithFPBackupPath needed by the faultproof test presets. * fix(tests): update optimism submodule to merged backup+challenger Updates tests/optimism to 32bd7c930 which includes PR #325 merge of backup support into op-succinct-sysgo branch. --------- Co-authored-by: Taehoon Kim <taehoon@succinct.xyz> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
haardikk21
pushed a commit
that referenced
this pull request
Mar 17, 2026
* feat: backup fp cache * docs: update proposer.md * test: unit and integration backup tests * fix: dedicated blocking thread pool * fix: test_proposer_backup_persistence * test: add recovery test with backup * fix: rebasing issue * nit: touchups * chore: rename to BACKUP_PATH * chore: address comments (#763) * chore(fault-proof): add comment explaining non-persisted backup fields * fix(fault-proof): use tempfile for atomic backup writes * fix(fault-proof): validate backup path at startup * feat(fault-proof): add backup metrics for observability * refactor(fault-proof): improve backup path validation and restore logic Consolidate duplicate if-let blocks, add tracing for restore operations, handle empty parent path edge case for relative paths, and log cleanup failures. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * test(fault-proof): add schema guard test for backup version Add a test that fails if Game or ProposerBackup fields change, reminding developers to bump BACKUP_VERSION when schema changes. This catches accidental schema changes that would break backup compatibility. * refactor(fault-proof): simplify backup restore logic Remove redundant path.exists() check before try_restore. Now only logs error metric when file exists but couldn't be parsed, avoiding double filesystem access and correctly distinguishing missing file from corrupt. * refactor(fault-proof): use tempfile for backup path write test Replace manual File::create + remove_file with NamedTempFile for the write permission check. Ensures cleanup on panic and is consistent with the atomic write approach used in backup.rs. --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> * refactor(fault-proof): remove duplicate backup restore log The log in ProposerState::try_restore() already provides restore information with game count and cursor details. * fix(tests): update optimism submodule for backup support The submodule was reverted to an older commit during a merge with main. This restores the correct commit that includes WithFPBackupPath needed by the faultproof test presets. * fix(tests): update optimism submodule to merged backup+challenger Updates tests/optimism to 32bd7c930 which includes PR #325 merge of backup support into op-succinct-sysgo branch. --------- Co-authored-by: Taehoon Kim <taehoon@succinct.xyz> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
mw2000
pushed a commit
that referenced
this pull request
Mar 19, 2026
* feat: backup fp cache * docs: update proposer.md * test: unit and integration backup tests * fix: dedicated blocking thread pool * fix: test_proposer_backup_persistence * test: add recovery test with backup * fix: rebasing issue * nit: touchups * chore: rename to BACKUP_PATH * chore: address comments (#763) * chore(fault-proof): add comment explaining non-persisted backup fields * fix(fault-proof): use tempfile for atomic backup writes * fix(fault-proof): validate backup path at startup * feat(fault-proof): add backup metrics for observability * refactor(fault-proof): improve backup path validation and restore logic Consolidate duplicate if-let blocks, add tracing for restore operations, handle empty parent path edge case for relative paths, and log cleanup failures. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * test(fault-proof): add schema guard test for backup version Add a test that fails if Game or ProposerBackup fields change, reminding developers to bump BACKUP_VERSION when schema changes. This catches accidental schema changes that would break backup compatibility. * refactor(fault-proof): simplify backup restore logic Remove redundant path.exists() check before try_restore. Now only logs error metric when file exists but couldn't be parsed, avoiding double filesystem access and correctly distinguishing missing file from corrupt. * refactor(fault-proof): use tempfile for backup path write test Replace manual File::create + remove_file with NamedTempFile for the write permission check. Ensures cleanup on panic and is consistent with the atomic write approach used in backup.rs. --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> * refactor(fault-proof): remove duplicate backup restore log The log in ProposerState::try_restore() already provides restore information with game count and cursor details. * fix(tests): update optimism submodule for backup support The submodule was reverted to an older commit during a merge with main. This restores the correct commit that includes WithFPBackupPath needed by the faultproof test presets. * fix(tests): update optimism submodule to merged backup+challenger Updates tests/optimism to 32bd7c930 which includes PR #325 merge of backup support into op-succinct-sysgo branch. --------- Co-authored-by: Taehoon Kim <taehoon@succinct.xyz> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
mw2000
pushed a commit
that referenced
this pull request
Mar 23, 2026
* feat: backup fp cache * docs: update proposer.md * test: unit and integration backup tests * fix: dedicated blocking thread pool * fix: test_proposer_backup_persistence * test: add recovery test with backup * fix: rebasing issue * nit: touchups * chore: rename to BACKUP_PATH * chore: address comments (#763) * chore(fault-proof): add comment explaining non-persisted backup fields * fix(fault-proof): use tempfile for atomic backup writes * fix(fault-proof): validate backup path at startup * feat(fault-proof): add backup metrics for observability * refactor(fault-proof): improve backup path validation and restore logic Consolidate duplicate if-let blocks, add tracing for restore operations, handle empty parent path edge case for relative paths, and log cleanup failures. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * test(fault-proof): add schema guard test for backup version Add a test that fails if Game or ProposerBackup fields change, reminding developers to bump BACKUP_VERSION when schema changes. This catches accidental schema changes that would break backup compatibility. * refactor(fault-proof): simplify backup restore logic Remove redundant path.exists() check before try_restore. Now only logs error metric when file exists but couldn't be parsed, avoiding double filesystem access and correctly distinguishing missing file from corrupt. * refactor(fault-proof): use tempfile for backup path write test Replace manual File::create + remove_file with NamedTempFile for the write permission check. Ensures cleanup on panic and is consistent with the atomic write approach used in backup.rs. --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> * refactor(fault-proof): remove duplicate backup restore log The log in ProposerState::try_restore() already provides restore information with game count and cursor details. * fix(tests): update optimism submodule for backup support The submodule was reverted to an older commit during a merge with main. This restores the correct commit that includes WithFPBackupPath needed by the faultproof test presets. * fix(tests): update optimism submodule to merged backup+challenger Updates tests/optimism to 32bd7c930 which includes PR #325 merge of backup support into op-succinct-sysgo branch. --------- Co-authored-by: Taehoon Kim <taehoon@succinct.xyz> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reverted_gas_used was implicitly typed as i32 due to gas_used as i32 cast. gas_used is u64 — the as i32 silently truncates the value. Changed to explicit u64 to match the gas type used throughout the codebase.