fix: fix reduced_flashblocks_number metric always recording zero#755
Closed
letmehateu wants to merge 1 commit intobase:mainfrom
Closed
fix: fix reduced_flashblocks_number metric always recording zero#755letmehateu wants to merge 1 commit intobase:mainfrom
letmehateu wants to merge 1 commit intobase:mainfrom
Conversation
Collaborator
🟡 Heimdall Review Status
|
Contributor
Author
|
@refcell sorry, can you check please my PR? |
Contributor
|
Can you please open an issue as per the contributing guidelines before making a PR thanks |
mw2000
pushed a commit
that referenced
this pull request
Mar 7, 2026
…migration (#755) * fix: AccessManager.sol should not burn all gas to run getLastProposalTimestamp * test: getLastProposerTimestamp * fix: forge fmt * fix: lt --------- Co-authored-by: Kien Nguyen <kien@riselabs.xyz>
mw2000
pushed a commit
that referenced
this pull request
Mar 9, 2026
…migration (#755) * fix: AccessManager.sol should not burn all gas to run getLastProposalTimestamp * test: getLastProposerTimestamp * fix: forge fmt * fix: lt --------- Co-authored-by: Kien Nguyen <kien@riselabs.xyz>
mw2000
pushed a commit
that referenced
this pull request
Mar 16, 2026
…migration (#755) * fix: AccessManager.sol should not burn all gas to run getLastProposalTimestamp * test: getLastProposerTimestamp * fix: forge fmt * fix: lt --------- Co-authored-by: Kien Nguyen <kien@riselabs.xyz>
haardikk21
pushed a commit
that referenced
this pull request
Mar 17, 2026
…migration (#755) * fix: AccessManager.sol should not burn all gas to run getLastProposalTimestamp * test: getLastProposerTimestamp * fix: forge fmt * fix: lt --------- Co-authored-by: Kien Nguyen <kien@riselabs.xyz>
mw2000
pushed a commit
that referenced
this pull request
Mar 19, 2026
…migration (#755) * fix: AccessManager.sol should not burn all gas to run getLastProposalTimestamp * test: getLastProposerTimestamp * fix: forge fmt * fix: lt --------- Co-authored-by: Kien Nguyen <kien@riselabs.xyz>
mw2000
pushed a commit
that referenced
this pull request
Mar 23, 2026
…migration (#755) * fix: AccessManager.sol should not burn all gas to run getLastProposalTimestamp * test: getLastProposerTimestamp * fix: forge fmt * fix: lt --------- Co-authored-by: Kien Nguyen <kien@riselabs.xyz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix reduced_flashblocks_number metric that always records 0 due to comparing self.config.flashblocks_per_block() against itself