fix(rpc): remove incorrect metrics increment in transaction_by_hash#131
Closed
sashaodessa wants to merge 1 commit intobase:mainfrom
Closed
fix(rpc): remove incorrect metrics increment in transaction_by_hash#131sashaodessa wants to merge 1 commit intobase:mainfrom
sashaodessa wants to merge 1 commit intobase:mainfrom
Conversation
Collaborator
|
This is not erroneous, since |
danyalprout
pushed a commit
that referenced
this pull request
Feb 12, 2026
refcell
pushed a commit
that referenced
this pull request
Feb 18, 2026
## Motivation alloy-rs/alloy#1349 ## Solution Same as alloy-rs/alloy#1397 ## PR Checklist - [x] Added Tests - [x] Added Documentation - [ ] Breaking changes
mw2000
pushed a commit
that referenced
this pull request
Mar 9, 2026
* feat: latest kona * fmt * fix * feat: small fixes, new elfs * nit: rm build * clippy * docs
mw2000
pushed a commit
that referenced
this pull request
Mar 16, 2026
* feat: latest kona * fmt * fix * feat: small fixes, new elfs * nit: rm build * clippy * docs
haardikk21
pushed a commit
that referenced
this pull request
Mar 17, 2026
* feat: latest kona * fmt * fix * feat: small fixes, new elfs * nit: rm build * clippy * docs
mw2000
pushed a commit
that referenced
this pull request
Mar 19, 2026
* feat: latest kona * fmt * fix * feat: small fixes, new elfs * nit: rm build * clippy * docs
mw2000
pushed a commit
that referenced
this pull request
Mar 23, 2026
* feat: latest kona * fmt * fix * feat: small fixes, new elfs * nit: rm build * clippy * docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
getTransactionByHashRPC method was incorrectly incrementing theget_transaction_receiptmetric when returning transactions from flashblocks cache. This caused metric pollution and reduced observability accuracy.Solution
get_transaction_receipt.increment(1)call from the flashblocks cache path intransaction_by_hash