feat(consensus): bincode compatibility for header and transaction types#1397
Merged
mattsse merged 13 commits intoalloy-rs:mainfrom Sep 30, 2024
Merged
feat(consensus): bincode compatibility for header and transaction types#1397mattsse merged 13 commits intoalloy-rs:mainfrom
mattsse merged 13 commits intoalloy-rs:mainfrom
Conversation
8f47037 to
af593d2
Compare
shekhirin
commented
Sep 29, 2024
| "dep:alloy-serde", | ||
| "alloy-eips/serde", | ||
| ] | ||
| serde-bincode-compat = ["serde_with"] |
Contributor
Author
There was a problem hiding this comment.
open to renaming this feature to something more generic than bincode, because it also unlocks messagepack via https://github.com/3Hren/msgpack-rust
484416c to
84956fe
Compare
shekhirin
commented
Sep 29, 2024
mattsse
reviewed
Sep 30, 2024
Member
mattsse
left a comment
There was a problem hiding this comment.
why is this required for all the tx types?
Contributor
Author
they have a |
mattsse
approved these changes
Sep 30, 2024
3 tasks
github-merge-queue bot
pushed a commit
to alloy-rs/op-alloy
that referenced
this pull request
Sep 30, 2024
## Motivation alloy-rs/alloy#1349 ## Solution Same as alloy-rs/alloy#1397 ## PR Checklist - [x] Added Tests - [x] Added Documentation - [ ] Breaking changes
lwedge99
pushed a commit
to sentioxyz/alloy
that referenced
this pull request
Oct 8, 2024
…es (alloy-rs#1397) * fix(serde): encode optional quantity as Some * use serialize_some * fix in other types too * feat(consensus): bincode compatibility for header and transaction types * add docs * reorganize modules * add legacy bincode compat impl, remove comments * less cows * fix doctest for legacy tx * rename feature * more info about limitation * remove special treatment for quantity fields
docker-dragonmj9ol
added a commit
to docker-dragonmj9ol/op-alloy
that referenced
this pull request
Nov 6, 2025
## Motivation alloy-rs/alloy#1349 ## Solution Same as alloy-rs/alloy#1397 ## PR Checklist - [x] Added Tests - [x] Added Documentation - [ ] Breaking changes
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 21, 2026
## Motivation alloy-rs/alloy#1349 ## Solution Same as alloy-rs/alloy#1397 ## PR Checklist - [x] Added Tests - [x] Added Documentation - [ ] Breaking changes
refcell
pushed a commit
to base/base
that referenced
this pull request
Feb 18, 2026
## Motivation alloy-rs/alloy#1349 ## Solution Same as alloy-rs/alloy#1397 ## PR Checklist - [x] Added Tests - [x] Added Documentation - [ ] Breaking changes
refcell
pushed a commit
to base/base
that referenced
this pull request
Feb 18, 2026
## Motivation alloy-rs/alloy#1349 ## Solution Same as alloy-rs/alloy#1397 ## PR Checklist - [x] Added Tests - [x] Added Documentation - [ ] Breaking changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1349
Introduces the
serde-bincode-compatfeature that provides bincode-compatible implementations of serde serialization/deserialization to use withserde_asmacro.Example usage
alloy/crates/consensus/src/header.rs
Lines 835 to 846 in af593d2