Add Python DIR plugin for prometheus metrics#911
Merged
sduehr merged 3 commits intobareos:masterfrom Oct 29, 2021
Merged
Conversation
sduehr
requested changes
Sep 30, 2021
Member
sduehr
left a comment
There was a problem hiding this comment.
I've suggested some changes for not having to use from bareosdir import *.
contrib/dir-plugins/prometheus/BareosDirPluginPrometheusExporter.py
Outdated
Show resolved
Hide resolved
contrib/dir-plugins/prometheus/BareosDirPluginPrometheusExporter.py
Outdated
Show resolved
Hide resolved
contrib/dir-plugins/prometheus/BareosDirPluginPrometheusExporter.py
Outdated
Show resolved
Hide resolved
contrib/dir-plugins/prometheus/BareosDirPluginPrometheusExporter.py
Outdated
Show resolved
Hide resolved
contrib/dir-plugins/prometheus/BareosDirPluginPrometheusExporter.py
Outdated
Show resolved
Hide resolved
contrib/dir-plugins/prometheus/BareosDirPluginPrometheusExporter.py
Outdated
Show resolved
Hide resolved
contrib/dir-plugins/prometheus/BareosDirPluginPrometheusExporter.py
Outdated
Show resolved
Hide resolved
contrib/dir-plugins/prometheus/BareosDirPluginPrometheusExporter.py
Outdated
Show resolved
Hide resolved
contrib/dir-plugins/prometheus/bareos-dir-prometheus-exporter.py
Outdated
Show resolved
Hide resolved
contrib/dir-plugins/prometheus/bareos-dir-prometheus-exporter.py
Outdated
Show resolved
Hide resolved
Member
Member
|
Hi, it would be nice if you could apply the suggested changes, so that we can merge this PR. |
sduehr
approved these changes
Oct 25, 2021
Member
sduehr
left a comment
There was a problem hiding this comment.
Thanks a lot for your contribution, looks good now.
8da8615 to
63c6593
Compare
Co-authored-by: sduehr <stephan.duehr@bareos.com>
63c6593 to
de04820
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a Python3 plugin for the Bareos director to submit job data to a Prometheus pushgateway.
This depends on a working python3 director setup and therefore on #881 to be working
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testing