Conversation
16 tasks
pstorz
requested changes
Sep 23, 2021
Member
pstorz
left a comment
There was a problem hiding this comment.
Good work.
Only two comments:
- If the asterisk imports cannot be avoided
- the CHANGELOG.md entry is missing
pstorz
requested changes
Sep 24, 2021
Member
pstorz
left a comment
There was a problem hiding this comment.
Thanks you for the explanation regarding the * imports.
What about the CHANGELOG.md entry?
29d9a45 to
15ba100
Compare
Member
Author
|
Added CHANGELOG.md entry. |
pstorz
approved these changes
Sep 30, 2021
Adapted the director and storagedaemon python plugin baseclasses to the modernized python plugin interface. Also changed the systemtests so that they use the baseclasses.
For the python director plugin, plugin_context must not be declared thread_local in bareosdir.h, otherwise DebugMessage will throw the plugin_ctx is unset runtime error after the bDirEventJobRun and bDirEventJobEnd events.
15ba100 to
4f5394b
Compare
This was referenced Sep 30, 2021
pstorz
added a commit
that referenced
this pull request
Oct 19, 2021
…ir-sd-plugin Adapt Python DIR and SD plugin Baseclasses to the modernized Python plugin API (backport of PR #923)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adapts the Python DIR and SD plugin Baseclasses to the modernized Python plugin API, see
https://docs.bareos.org/TasksAndConcepts/Plugins.html#modernization-of-the-python-plugin-api
It also contains a fix for the DIR plugin, where DebugMessage after certain events caused
a plugin_ctx is unset runtime error.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testing