Skip to content

Bugfix: Director Python Plugin Baseclass replace obsolete bareos_dir_consts#881

Closed
benibr wants to merge 4 commits intobareos:masterfrom
benibr:bugfix/dir_py_baseclass
Closed

Bugfix: Director Python Plugin Baseclass replace obsolete bareos_dir_consts#881
benibr wants to merge 4 commits intobareos:masterfrom
benibr:bugfix/dir_py_baseclass

Conversation

@benibr
Copy link
Contributor

@benibr benibr commented Jun 30, 2021 •
edited by joergsteffens
Loading

This PR should make the Director python plugin baseclass ready for bareos 20 with python3
It replaces the imports and other naming conventions of eventtypes, consts, etc. according to the doc

See also:
https://bugs.bareos.org/view.php?id=1332
https://support.bareos.com/index.php?module=HelpDesk&view=Detail&id=17x55442

OP#4884

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems
  • git status should not report modifications in the source tree after building and testing
Tests
  • Decision taken that a system- or unittest is required (if not, then remove this paragraph)
  • The decision towards a systemtest is reasonable compared to a unittest
  • Testname matches exactly what is being tested
  • Output of the test leads quickly to the origin of the fault

@pstorz pstorz requested a review from sduehr July 1, 2021 09:11
@aussendorf
Copy link
Contributor

aussendorf commented Jul 8, 2021

Needs to be aligned with #PR877, both effect baseclass.

@benibr
Copy link
Contributor Author

benibr commented Jul 19, 2021

What exactly do you mean with "aligned"? The changes in the BaseClass in #877 differ from the ones I made. Eg. bRCs[b"bRC_OK"] vs. bRC_OK as returncodes.
Someone have to decide which way it should be merged.

@benibr benibr mentioned this pull request Jul 19, 2021
Closed
16 tasks
@benibr benibr mentioned this pull request Aug 16, 2021
Merged
12 tasks
sduehr
sduehr reviewed Sep 14, 2021
View reviewed changes
Copy link
Member

@sduehr sduehr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, as we've had conflicting contributions for BareosDirPluginBaseclass.py from this PR and PR #877, I've created the new PR #923 which also contains an adapte SD plugin baseclass and
a fix for the plugin_ctx is unset runtime error.

@sduehr
Copy link
Member

sduehr commented Sep 30, 2021

Meanwhile PR #923 (which involves the changes from both this PR and PR #877) has been merged into master, so we can close this PR. Thanks for your contribution.

@sduehr sduehr closed this Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sduehr sduehr sduehr left review comments

Assignees

@sduehr sduehr

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@benibr @aussendorf @sduehr