config: add virtual file changer example + documentation by bruno-at-bareos · Pull Request #2090 · bareos/bareos

bruno-at-bareos · 2024-12-24T15:50:05Z

This PR aims to introduce configuration example files for using an
autochanger with virtual disk autonumbered devices.

We also revisit some related chapter of the documentation.

device_resource.cc: fix typo and alignment
config: add virtual disk changer to default configuration
doc: update indexes syntax, rewrap paragraph
doc: volume management chapter improvement

After first presentation (2024-01-14), we want to rename disk to file, to respect the rest of the configuration CamelCase should be used, but it is not as practical and equivalent our tape changer is all lowercase.
We want to avoid name finishing with -

Please check

Short description and the purpose of this PR is present above this paragraph
Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General

Is the PR title usable as CHANGELOG entry?
Purpose of the PR is understood
Commit descriptions are understandable and well formatted
Required backport PRs have been created
Correct milestone is set

Source code quality

Source code changes are understandable
Variable and function names are meaningful
Code comments are correct (logically and spelling)
Required documentation changes are present and part of the PR

TODO

Installed the packages and enabled the example files to see if it works

...c/stored/backends/unix_file_device.d/bareos-sd.d/autochanger/FilechangerStorage.conf.example

core/src/stored/backends/unix_file_device.d/bareos-sd.d/device/vfile.conf.example

core/src/stored/backends/unix_file_device.d/bareos-dir.d/storage/Filechanger.conf.example

pstorz

Unfortunately was not able to install as we do not have current packages.

bruno-at-bareos · 2025-02-04T08:50:14Z

Unfortunately was not able to install as we do not have current packages.

With your proposed changes a rebuild has been triggered, so packages should be available today.

wizhippo · 2025-02-10T14:57:56Z

This configuration has the initial device "vfile0000" "reserved for storage and labeling".

Testing I did a restore and it used vfile0001 by default with no option given to select the reserved device. Is this expected? How is the reserved device used? Does a restore job need to be created that takes advantage of this reserved device? Does it only come into play if none of the vfile0001 - vfile0xxx are available and it then will let you mount the revered device?

Perhaps a some documentation could be added to clarify its use?

bruno-at-bareos · 2025-02-10T15:58:35Z

Unfortunately was not able to install as we do not have current packages.
@pstorz New packages have been created on Feb 10th.

bruno-at-bareos · 2025-02-10T16:11:31Z

This configuration has the initial device "vfile0000" "reserved for storage and labeling".

Testing I did a restore and it used vfile0001 by default with no option given to select the reserved device. Is this expected? How is the reserved device used? Does a restore job need to be created that takes advantage of this reserved device? Does it only come into play if none of the vfile0001 - vfile0xxx are available and it then will let you mount the revered device?

Perhaps a some documentation could be added to clarify its use?

Interesting comment, I will have a check

@wizhippo to let the drive available for restore, you need to set the drive in autoselect=yes mode, then you have a drive more free, but you can't request directly the restore to use it.
So while that reserved drive is super useful for label, it might not be as much for restores especially if the queue of waiting jobs is large, But still can help.

bruno-at-bareos

I don't think that renaming to File will improve the situation.
My vote is against for the reason given in the review

core/src/stored/backends/unix_file_device.d/bareos-dir.d/storage/Filechanger.conf.example.in

bruno-at-bareos · 2025-03-27T14:44:17Z

Important commit for documentation and defaultconfig not directly related are now extracted and presented in #2225

bruno-at-bareos · 2025-04-14T13:04:42Z

Today meeting we decided to setup the example and the configuration, like it was done to replace the default distributed File and FileStorage allowing end user to switch in place jobs without touching any further their configuration.

pstorz

Very good work! Thank you bruno.

...c/stored/backends/unix_file_device.d/bareos-sd.d/autochanger/FilechangerStorage.conf.example

core/src/stored/backends/unix_file_device.d/bareos-sd.d/device/vfile.conf.example

- update indexes syntax. - rewrap paragraph. - cleanup example from oldies - remove and adjust `Maximum Concurrent Jobs` - introduce virtual file autochanger with auto-numbered devices. - fix spelling Directory -> |dir| - standardize parameters spelling - use relative positionning into the rst to source directly config example in sources. config: add virtual disk changer example `bareos-dir.d/storage/File.conf.example` is using storage resource defined in `bareos-sd.d/autochanger/FileStorage.conf.example` virtual file changer is using autonumbered devices defined in `bareos-sd.d/devices/File.conf.example` - create virtual_diskchanger.d backend configuration to use unix_file_device.d backend - packaging: add example files to all platforms - File.conf.example: set Address and Password to be fill'up with post install scripts - named the changer File so it can replace the default distributed DIR File storage ressource and FileStorage ressource on SD Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com> Co-authored-by: Philipp Storz <philipp.storz@bareos.com>

With bareos#2090 *.conf.example files get modified when installing a package. on RPM based distributions `rpm -V` should not lead to a altered package warning. `*.example.conf` files are marked as config files in the spec file. Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>

With bareos#2090 *.conf.example files get modified when installing a package. on RPM based distributions `rpm -V` should not lead to a altered package warning. `*.example.conf` files are marked as config files in the spec file. Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com> (cherry picked from commit 8f784bb)

With bareos#2090 *.conf.example files get modified when installing a package. on RPM based distributions `rpm -V` should not lead to a altered package warning. `*.example.conf` files are marked as config files in the spec file. Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>

With bareos#2090 *.conf.example files get modified when installing a package. on RPM based distributions `rpm -V` should not lead to a altered package warning. `*.example.conf` files are marked as config files in the spec file. Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com> (cherry picked from commit 8f784bb)

With bareos#2090 *.conf.example files get modified when installing a package. on RPM based distributions `rpm -V` should not lead to a altered package warning. `*.example.conf` files are marked as config files in the spec file. Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>

bruno-at-bareos mentioned this pull request Dec 24, 2024

default config: use virtual disk changer as FileStorage #1467

Closed

15 tasks

bruno-at-bareos force-pushed the dev/bruno/master/default-config-add-virtual-disk-changer-example branch 4 times, most recently from b28db39 to 7ba14b2 Compare January 6, 2025 13:49

bruno-at-bareos linked an issue Jan 13, 2025 that may be closed by this pull request

Update documentation for "IgnoreCase". Probably you do not want to enable that on windows. #2112

Closed

bruno-at-bareos marked this pull request as ready for review January 13, 2025 09:52

bruno-at-bareos self-assigned this Jan 13, 2025

bruno-at-bareos force-pushed the dev/bruno/master/default-config-add-virtual-disk-changer-example branch from e5637f2 to 54b319e Compare January 13, 2025 10:40

bruno-at-bareos added the draft label Jan 14, 2025

bruno-at-bareos changed the title ~~config: add virtual disk changer example + documentation~~ config: add virtual file changer example + documentation Jan 14, 2025

bruno-at-bareos marked this pull request as draft January 14, 2025 14:01

bruno-at-bareos force-pushed the dev/bruno/master/default-config-add-virtual-disk-changer-example branch from f25da90 to 2b98257 Compare January 20, 2025 09:06

bruno-at-bareos mentioned this pull request Jan 20, 2025

bconsole: enable app icon on windows #2105

Merged

16 tasks

bruno-at-bareos marked this pull request as ready for review January 27, 2025 09:57

bruno-at-bareos removed the draft label Jan 27, 2025

bruno-at-bareos requested a review from pstorz January 28, 2025 10:36

bruno-at-bareos assigned pstorz Jan 28, 2025

pstorz requested changes Feb 3, 2025

View reviewed changes

pstorz self-requested a review February 3, 2025 16:02

pstorz requested changes Feb 3, 2025

View reviewed changes

bruno-at-bareos force-pushed the dev/bruno/master/default-config-add-virtual-disk-changer-example branch from 8831976 to e15d126 Compare February 10, 2025 13:36

arogge requested a review from pstorz February 11, 2025 10:58

pstorz force-pushed the dev/bruno/master/default-config-add-virtual-disk-changer-example branch from 287c5c7 to d0e7d6e Compare February 27, 2025 05:54

bruno-at-bareos commented Mar 3, 2025

View reviewed changes

core/src/stored/backends/unix_file_device.d/bareos-dir.d/storage/Filechanger.conf.example.in Outdated Show resolved Hide resolved

bruno-at-bareos mentioned this pull request Mar 25, 2025

Remove deprecated MaximumConcurrentJobs from default configuration #2219

Closed

bruno-at-bareos removed a link to an issue Apr 8, 2025

Update documentation for "IgnoreCase". Probably you do not want to enable that on windows. #2112

Closed

bruno-at-bareos force-pushed the dev/bruno/master/default-config-add-virtual-disk-changer-example branch from 7010a78 to 77fe07a Compare April 8, 2025 14:53

bruno-at-bareos mentioned this pull request Apr 9, 2025

stored: implicitly create autochanger from device with count > 1 #2198

Merged

18 tasks

bruno-at-bareos force-pushed the dev/bruno/master/default-config-add-virtual-disk-changer-example branch from 2adec63 to 82e9e42 Compare April 15, 2025 07:53

bruno-at-bareos added enhancement requires backport to 24 labels Apr 15, 2025

bruno-at-bareos added this to the 25.0.0 milestone Apr 15, 2025

pstorz approved these changes Apr 16, 2025

View reviewed changes

...c/stored/backends/unix_file_device.d/bareos-sd.d/autochanger/FilechangerStorage.conf.example Outdated Show resolved Hide resolved

core/src/stored/backends/unix_file_device.d/bareos-sd.d/device/vfile.conf.example Outdated Show resolved Hide resolved

bruno-at-bareos and others added 2 commits April 16, 2025 10:23

config-lib.sh: configure .conf.example files

1be752c

pstorz force-pushed the dev/bruno/master/default-config-add-virtual-disk-changer-example branch from e34e466 to 1be752c Compare April 16, 2025 08:24

bruno-at-bareos mentioned this pull request Apr 16, 2025

config: add virtual file changer example + documentation #2248

Merged

7 tasks

Update CHANGELOG.md

70882a3

BareosBot merged commit 1b11c19 into bareos:master Apr 16, 2025
1 check was pending

florian-at-bareos added a commit to florian-at-bareos/bareos that referenced this pull request Apr 23, 2025

docs: update documentation after bareos#2090 merge

6cb508f

bruno-at-bareos mentioned this pull request May 12, 2025

packaging: set all *.conf.examples as %config(noreplace) #2268

Merged

11 tasks

florian-at-bareos added a commit to florian-at-bareos/bareos that referenced this pull request May 20, 2025

docs: update documentation after bareos#2090 merge

b908829

bruno-at-bareos deleted the dev/bruno/master/default-config-add-virtual-disk-changer-example branch July 24, 2025 11:47

sebsura pushed a commit to florian-at-bareos/bareos that referenced this pull request Sep 22, 2025

docs: update documentation after bareos#2090 merge

c94bf40

sebsura pushed a commit to florian-at-bareos/bareos that referenced this pull request Oct 13, 2025

docs: update documentation after bareos#2090 merge

cbb9c35

arogge pushed a commit to florian-at-bareos/bareos that referenced this pull request Oct 30, 2025

docs: update documentation after bareos#2090 merge

4f94a69

sebsura pushed a commit to florian-at-bareos/bareos that referenced this pull request Oct 31, 2025

docs: update documentation after bareos#2090 merge

1e6c3c7

sebsura pushed a commit to florian-at-bareos/bareos that referenced this pull request Oct 31, 2025

docs: update documentation after bareos#2090 merge

406273e

Conversation

bruno-at-bareos commented Dec 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Please check

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General

Source code quality

TODO

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pstorz left a comment

Choose a reason for hiding this comment

Uh oh!

bruno-at-bareos commented Feb 4, 2025

Uh oh!

wizhippo commented Feb 10, 2025

Uh oh!

bruno-at-bareos commented Feb 10, 2025

Uh oh!

bruno-at-bareos commented Feb 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bruno-at-bareos left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bruno-at-bareos commented Mar 27, 2025

Uh oh!

bruno-at-bareos commented Apr 14, 2025

Uh oh!

pstorz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bruno-at-bareos commented Dec 24, 2024 •

edited

Loading

bruno-at-bareos commented Feb 10, 2025 •

edited

Loading