fix MaximumConcurrentJobs in docs and defaultsconfig#2225
Merged
BareosBot merged 9 commits intobareos:masterfrom Apr 3, 2025
Conversation
5daa648 to
46207ae
Compare
12 tasks
7 tasks
pstorz
requested changes
Apr 3, 2025
Member
pstorz
left a comment
There was a problem hiding this comment.
Good work! I have two small changes.
.../source/manually_added_config_directive_descriptions/fd-client-MaximumConcurrentJobs.rst.inc
Outdated
Show resolved
Hide resolved
...source/manually_added_config_directive_descriptions/sd-storage-MaximumConcurrentJobs.rst.inc
Outdated
Show resolved
Hide resolved
pstorz
approved these changes
Apr 3, 2025
- rewrite chapter about Concurrent Jobs - add deprecated statement MaximumConcurrentJobs We missed to update the documentation when those FD and SD parameter get deprecated. - new recommendation is remove to parameter Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
- removed from bareos-fd myself.conf - removed from bareos-sd bareos-sd.conf Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
- fix copyright year Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
- update indexes syntax - rewrap paragraph Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
Remove obsolete advise to set it to yes, on modern system you should let it to default no. Fix issue bareos#2112 Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
Co-authored-by: Philipp Storz <philipp.storz@bareos.com>
05220a0 to
91205af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Those commits were initially included in PR #2090, but we want to have them integrated as soon as possible.
doc: cleanup MaximumConcurrentJob
defaultconfig: remove deprecated
MaximumConcurrentJobsdefaultconfigs: remove semi-colon, standardize parameters
device_resource.cc: fix typo and alignment
doc: update StorageDaemon.rst
doc: fix new vmware documentation url
doc: IgnoreCase remove advise for Windows
systemtest trying to load defaultconfigswill be done into a separate PR related to issue defaultconfig should be systemtested #2237Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality