Skip to content

catreq.cc: suppress missing batch con warning#1584

Merged
BareosBot merged 3 commits intobareos:bareos-22from
pstorz:dev/pstorz/bareos-22/backport-of-1578
Nov 9, 2023
Merged

catreq.cc: suppress missing batch con warning#1584
BareosBot merged 3 commits intobareos:bareos-22from
pstorz:dev/pstorz/bareos-22/backport-of-1578

Conversation

@pstorz
Copy link
Member

@pstorz pstorz commented Nov 2, 2023 •
edited by arogge
Loading

Thank you for contributing to the Bareos Project!

Backport of PR #1578 to bareos-22

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Check backport line
  • Required backport PRs have been created
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR

@pstorz pstorz requested a review from arogge November 2, 2023 11:47
pstorz and others added 3 commits November 9, 2023 11:39
@pstorz @BareosBot
catreq.cc: suppress missing batch con warning
f9afd8e 
When the Update_filelist command is received, the code issued a warning
though this is not required.

(cherry picked from commit 0f02136)
@pstorz @BareosBot
catreq.cc: debug message added for no db_batch condition
6563d68 
(cherry picked from commit 68024bc)
@BareosBot
Update CHANGELOG.md
7877a5d
@BareosBot BareosBot force-pushed the dev/pstorz/bareos-22/backport-of-1578 branch from 4933d4f to 7877a5d Compare November 9, 2023 11:39
@BareosBot BareosBot merged commit 94df3be into bareos:bareos-22 Nov 9, 2023
bruno-at-bareos added a commit to bruno-at-bareos/bareos that referenced this pull request Jan 9, 2024
@bruno-at-bareos
plugins: postgresql fix missing pb_backup_stop() call
4b1974e 
- pg_backup_stop() is called in all job level
- add in testrunner-default checks of WARNING or ERROR in db logs

Fixes bareos#1584: Incremental PostgreSQL backup will log an warning on
             the database server

Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
bruno-at-bareos added a commit to bruno-at-bareos/bareos that referenced this pull request Jan 9, 2024
@bruno-at-bareos
plugins: postgresql fix missing pg_backup_stop() call
c43c826 
- pg_backup_stop() is called in all job level
- add in testrunner-default checks of WARNING or ERROR in db logs

Fixes bareos#1584: Incremental PostgreSQL backup will log an warning on
             the database server

Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
@bruno-at-bareos bruno-at-bareos mentioned this pull request Jan 9, 2024
Merged
15 tasks
bruno-at-bareos added a commit to bruno-at-bareos/bareos that referenced this pull request Jan 11, 2024
@bruno-at-bareos
plugins: postgresql fix missing pg_backup_stop() call
fe5e37a 
- pg_backup_stop() is called in all job level depending of the
  `backup_running` status. This allow a better support of
  incremental with no changes.
- add in testrunner-default checks of WARNING or ERROR in db logs
  activity nor changes to backup.

Fixes bareos#1584: Incremental PostgreSQL backup will log an warning on
             the database server

Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
bruno-at-bareos added a commit to bruno-at-bareos/bareos that referenced this pull request Jan 11, 2024
@bruno-at-bareos
plugins: postgresql fix missing pg_backup_stop() call
08a63df 
- pg_backup_stop() is called in all job level depending of the
  `backup_running` status. This allow a better support of
  incremental with no changes.
- add in testrunner-default checks of WARNING or ERROR in cluster
  logs

Fixes bareos#1584: Incremental PostgreSQL backup will log an warning on
             the database server

Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
bruno-at-bareos added a commit to bruno-at-bareos/bareos that referenced this pull request Jan 15, 2024
@bruno-at-bareos
plugins: postgresql fix missing pg_backup_stop() call
d1476a8 
- pg_backup_stop() is called in all job level depending of the
  `backup_running` status. This allow a better support of
  incremental with no changes.
- add in testrunner-default checks of WARNING or ERROR in cluster
  logs
- is_backup_running boolean true if pg_backup_start has been run
- is_backup_full boolean true if backup level is Full
- apply black 24 suggestion

Fixes bareos#1584: Incremental PostgreSQL backup will log an warning on
             the database server

Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
bruno-at-bareos added a commit to bruno-at-bareos/bareos that referenced this pull request Jan 15, 2024
@bruno-at-bareos
plugins: postgresql fix missing pg_backup_stop() call
fce655d 
- pg_backup_stop() is called in all job level depending of the
  `backup_running` status. This allow a better support of
  incremental with no changes.
- add in testrunner-default checks of WARNING or ERROR in cluster
  logs
- is_backup_running boolean true if pg_backup_start has been run
- is_backup_full boolean true if backup level is Full
- apply black 24 suggestion

Fixes bareos#1584: Incremental PostgreSQL backup will log an warning on
             the database server

Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
(cherry picked from commit d1476a8)
bruno-at-bareos added a commit to bruno-at-bareos/bareos that referenced this pull request Jan 16, 2024
@bruno-at-bareos
plugins: postgresql fix missing pg_backup_stop() call
b5f2eb1 
- pg_backup_stop() is called in all job level depending of the
  `backup_running` status. This allow a better support of
  incremental with no changes.
- add in testrunner-default checks of WARNING or ERROR in cluster
  logs
- is_backup_running boolean true if pg_backup_start has been run
- is_backup_full boolean true if backup level is Full
- apply black formatting suggestion

Fixes bareos#1584: Incremental PostgreSQL backup will log an warning on
             the database server

Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
bruno-at-bareos added a commit to bruno-at-bareos/bareos that referenced this pull request Jan 16, 2024
@bruno-at-bareos
plugins: postgresql fix missing pg_backup_stop() call
e10bb90 
- pg_backup_stop() is called in all job level depending of the
  `backup_running` status. This allow a better support of
  incremental with no changes.
- add in testrunner-default checks of WARNING or ERROR in cluster
  logs
- is_backup_running boolean true if pg_backup_start has been run
- is_backup_full boolean true if backup level is Full
- apply black formatting suggestion

Fixes bareos#1584: Incremental PostgreSQL backup will log an warning on
             the database server

Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
(cherry picked from commit b5f2eb1)
BareosBot pushed a commit to bruno-at-bareos/bareos that referenced this pull request Jan 16, 2024
@bruno-at-bareos @BareosBot
plugins: postgresql fix missing pg_backup_stop() call
1b12ddd 
- pg_backup_stop() is called in all job level depending of the
  `backup_running` status. This allow a better support of
  incremental with no changes.
- add in testrunner-default checks of WARNING or ERROR in cluster
  logs
- is_backup_running boolean true if pg_backup_start has been run
- is_backup_full boolean true if backup level is Full
- apply black formatting suggestion

Fixes bareos#1584: Incremental PostgreSQL backup will log an warning on
             the database server

Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
(cherry picked from commit b5f2eb1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arogge arogge arogge approved these changes

Assignees

No one assigned

Labels

is a backport to 22

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pstorz @arogge @BareosBot