Skip to content

catreq.cc: suppress missing batch con warning#1578

Merged
BareosBot merged 3 commits intobareos:masterfrom
pstorz:dev/pstorz/master/no-warning-on-update_filelist-when-no-batch-started
Nov 3, 2023
Merged

catreq.cc: suppress missing batch con warning#1578
BareosBot merged 3 commits intobareos:masterfrom
pstorz:dev/pstorz/master/no-warning-on-update_filelist-when-no-batch-started

Conversation

@pstorz
Copy link
Member

@pstorz pstorz commented Oct 26, 2023 •
edited by arogge
Loading

When the Update_filelist command is received, the code issued a warning though this is not required.

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Required backport PRs have been created
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR

@bruno-at-bareos bruno-at-bareos self-assigned this Oct 26, 2023
@bruno-at-bareos
Copy link
Contributor

bruno-at-bareos commented Oct 26, 2023 •
edited
Loading

Looks good in first review, but I would really like to understand why I'm seeing this in joblog

26-Oct 13:32 bareos-sd JobId 3: Doing timed backup checkpoint. Next checkpoint in 3 seconds
26-Oct 13:32 bareos-dir JobId 3: Insert of attributes batch table with 1 entries start
26-Oct 13:32 bareos-dir JobId 3: Insert of attributes batch table done
. . .
26-Oct 13:32 bareos-sd JobId 3: stored/checkpoint_handler.cc:75 Volume changed, doing checkpoint:
26-Oct 13:32 bareos-dir JobId 3: Insert of attributes batch table with 1 entries start
26-Oct 13:32 bareos-dir JobId 3: Insert of attributes batch table done

When we have Spool Attributes not set in the checkpoints tests, so no batch should be in use.

sebsura
sebsura reviewed Oct 27, 2023
View reviewed changes
Copy link
Contributor

@sebsura sebsura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we do not want a job message, we should leave at least a debug message.

@bruno-at-bareos
Copy link
Contributor

bruno-at-bareos commented Nov 2, 2023

@sebsura

If we do not want a job message, we should leave at least a debug message.

Why we would like this debug as no action is simply required.
If we go a debug message, we should have one that say operation done.

bruno-at-bareos
bruno-at-bareos approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with the changes, Approved.

@arogge arogge added the bugfix label Nov 2, 2023
@pstorz pstorz force-pushed the dev/pstorz/master/no-warning-on-update_filelist-when-no-batch-started branch from 9d2e0cc to 68024bc Compare November 2, 2023 11:42
@pstorz pstorz mentioned this pull request Nov 2, 2023
Merged
10 tasks
pstorz and others added 3 commits November 3, 2023 11:29
@pstorz @BareosBot
catreq.cc: suppress missing batch con warning
1a3ba06 
When the Update_filelist command is received, the code issued a warning
though this is not required.
@pstorz @BareosBot
catreq.cc: debug message added for no db_batch condition
86deb1a
@BareosBot
Update CHANGELOG.md
449482a
@BareosBot BareosBot force-pushed the dev/pstorz/master/no-warning-on-update_filelist-when-no-batch-started branch from 9b2f4c1 to 449482a Compare November 3, 2023 11:29
@BareosBot BareosBot merged commit be1525c into bareos:master Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sebsura sebsura sebsura left review comments

@arogge arogge arogge approved these changes

@bruno-at-bareos bruno-at-bareos bruno-at-bareos approved these changes

Assignees

@bruno-at-bareos bruno-at-bareos

Labels

requires backport to 22

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pstorz @bruno-at-bareos @arogge @sebsura @BareosBot