dird: fix llist jobs current not displaying correct data#1025
Merged
pstorz merged 5 commits intobareos:masterfrom Dec 16, 2021
Merged
Conversation
ead53d1 to
15f586a
Compare
12 tasks
8829945 to
5a67612
Compare
caught wrongly deleted column, and added `job.`
3f47abd to
93ddb03
Compare
added 4 commits
December 16, 2021 16:37
Setting ACL filters and resource filters requires knowledge of the exact position of the query columns. Since the query was updated to show duration which was put just in the middle after starttime and endtime, the subsequent columns positions were incremented which rendered the code obsolete. So this commit updates the positions of the required columns
removed initial test, and changed it with a python one
93ddb03 to
c22d267
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
PR #1007 introduced a new duration column when listing jobs. Since the column was added in the middle of the selection, the following columns positions were shifted. Those positions are important for certain filtering to happen. Since positions are changed, filtering does not work properly resulting in the issue. This PR fixes the problem and adds extra tests.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testing