Skip to content

webui and console: add job duration info in job listings#1007

Merged
pstorz merged 6 commits intobareos:masterfrom
alaaeddineelamri:dev/alaaeddineelamri/master/job-duration-column
Dec 6, 2021
Merged

webui and console: add job duration info in job listings#1007
pstorz merged 6 commits intobareos:masterfrom
alaaeddineelamri:dev/alaaeddineelamri/master/job-duration-column

Conversation

@alaaeddineelamri
Copy link
Contributor

@alaaeddineelamri alaaeddineelamri commented Nov 29, 2021

Description:

This PR adds a duration column to the list jobs command to have a better idea of how long jobs take to run.
The duration information is displayed both in the console (cli) and also in the webui.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems
  • git status should not report modifications in the source tree after building and testing

@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaaeddineelamri/master/job-duration-column branch from 5eb73b1 to 55bc7ff Compare November 29, 2021 15:55
@frb121 frb121 force-pushed the dev/alaaeddineelamri/master/job-duration-column branch from 9259e03 to a40c22f Compare November 30, 2021 13:45
@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaaeddineelamri/master/job-duration-column branch from a40c22f to 0aa2378 Compare December 1, 2021 09:50
@frb121 frb121 force-pushed the dev/alaaeddineelamri/master/job-duration-column branch 3 times, most recently from 16fac91 to 3323b13 Compare December 3, 2021 11:57
@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaaeddineelamri/master/job-duration-column branch from fb83ed1 to 2f0748e Compare December 3, 2021 12:11
@pstorz pstorz changed the title Cats: Job duration in job listings user interfaces: add job duration in job listings Dec 6, 2021
@pstorz pstorz changed the title user interfaces: add job duration in job listings user interfaces: add job duration info in job listings Dec 6, 2021
@pstorz pstorz changed the title user interfaces: add job duration info in job listings webui and console: add job duration info in job listings Dec 6, 2021
@pstorz pstorz force-pushed the dev/alaaeddineelamri/master/job-duration-column branch from 2f0748e to 2557735 Compare December 6, 2021 11:05
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

Job.StartTime,
CASE
WHEN endtime IS NOT NULL THEN endtime - starttime
ELSE CURRENT_TIMESTAMP - starttime
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ELSE CURRENT_TIMESTAMP - starttime
ELSE CURRENT_TIMESTAMP(0) - starttime

@pstorz pstorz merged commit db05b36 into bareos:master Dec 6, 2021
@pstorz pstorz deleted the dev/alaaeddineelamri/master/job-duration-column branch December 6, 2021 11:06
joergsteffens added a commit that referenced this pull request Mar 25, 2024
BigSqlQuery fetches data in 100 row chunks.
This change makes sure, that subsequent chunks
also have valid header information.

Fixes: #1007: JSON API: 'list files' returns malformed json
joergsteffens added a commit that referenced this pull request Mar 27, 2024
BigSqlQuery fetches data in 100 row chunks.
This change makes sure, that subsequent chunks
also have valid header information.

Fixes: #1007: JSON API: 'list files' returns malformed json

Co-authored-by: Sebastian Sura <124262655+sebsura@users.noreply.github.com>
joergsteffens added a commit to joergsteffens/bareos that referenced this pull request Mar 27, 2024
BigSqlQuery fetches data in 100 row chunks.
This change makes sure, that subsequent chunks
also have valid header information.

Fixes: bareos#1007: JSON API: 'list files' returns malformed json

Co-authored-by: Sebastian Sura <124262655+sebsura@users.noreply.github.com>
(cherry picked from commit 2168ccd)
joergsteffens added a commit to joergsteffens/bareos that referenced this pull request Mar 27, 2024
BigSqlQuery fetches data in 100 row chunks.
This change makes sure, that subsequent chunks
also have valid header information.

Fixes: bareos#1007: JSON API: 'list files' returns malformed json

Co-authored-by: Sebastian Sura <124262655+sebsura@users.noreply.github.com>
(cherry picked from commit 2168ccd)
joergsteffens added a commit to joergsteffens/bareos that referenced this pull request Mar 27, 2024
BigSqlQuery fetches data in 100 row chunks.
This change makes sure, that subsequent chunks
also have valid header information.

Fixes: bareos#1007: JSON API: 'list files' returns malformed json

Co-authored-by: Sebastian Sura <124262655+sebsura@users.noreply.github.com>
(cherry picked from commit 2168ccd)
(cherry picked from commit e6cea14)
BareosBot pushed a commit that referenced this pull request Mar 27, 2024
BigSqlQuery fetches data in 100 row chunks.
This change makes sure, that subsequent chunks
also have valid header information.

Fixes: #1007: JSON API: 'list files' returns malformed json

Co-authored-by: Sebastian Sura <124262655+sebsura@users.noreply.github.com>
joergsteffens added a commit to joergsteffens/bareos that referenced this pull request Mar 27, 2024
BigSqlQuery fetches data in 100 row chunks.
This change makes sure, that subsequent chunks
also have valid header information.

Fixes: bareos#1007: JSON API: 'list files' returns malformed json

Co-authored-by: Sebastian Sura <124262655+sebsura@users.noreply.github.com>
(cherry picked from commit 2168ccd)
joergsteffens added a commit to joergsteffens/bareos that referenced this pull request Mar 28, 2024
BigSqlQuery fetches data in 100 row chunks.
This change makes sure, that subsequent chunks
also have valid header information.

Fixes: bareos#1007: JSON API: 'list files' returns malformed json

Co-authored-by: Sebastian Sura <124262655+sebsura@users.noreply.github.com>
(cherry picked from commit 2168ccd)
BareosBot pushed a commit to joergsteffens/bareos that referenced this pull request Mar 28, 2024
BigSqlQuery fetches data in 100 row chunks.
This change makes sure, that subsequent chunks
also have valid header information.

Fixes: bareos#1007: JSON API: 'list files' returns malformed json

Co-authored-by: Sebastian Sura <124262655+sebsura@users.noreply.github.com>
(cherry picked from commit 2168ccd)
(cherry picked from commit e6cea14)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants