Conversation
Contributor
|
if we merge PR #1025 first, we can add a test to the python-bareos list_jobs test |
a31a6b6 to
3653d91
Compare
If both keywords count and current were given, the output filter for the rows were set while the result only will contain one column. When the filter accesses the non-existent column it crashes. Now only the filters for current are set if count is not set.
3653d91 to
bf5215e
Compare
alaaeddineelamri
approved these changes
Dec 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If both keywords count and current were given in the "list jobs" command, the output filter for the
rows were set while the result only will contain one column. When the
filter accesses the non-existent column it crashes.
Now only the filters for current are set if count is not set.
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testing