Skip to content

Remove unneeded dependencies from babel-generator#3460

Closed
dlwalsh wants to merge 1 commit intobabel:masterfrom
dlwalsh:generator-removedeps
Closed

Remove unneeded dependencies from babel-generator#3460
dlwalsh wants to merge 1 commit intobabel:masterfrom
dlwalsh:generator-removedeps

Conversation

@dlwalsh
Copy link
Copy Markdown
Contributor

@dlwalsh dlwalsh commented Apr 9, 2016

I've updated babel-generator to replace the packages is-integer, repeating, trim-right with Number.isInteger, _.repeat and _.trimRight respectively.

Lodash is already a dependency so this adds nothing new.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 9, 2016

Current coverage is 85.49%

Merging #3460 into master will decrease coverage by -0.33% as of 81917f0

@@            master   #3460   diff @@
======================================
  Files          197     197       
  Stmts        12171   12170     -1
  Branches      2502    2502       
  Methods          0       0       
======================================
- Hit          10446   10405    -41
- Partial        519     559    +40
  Missed        1206    1206

Review entire Coverage Diff as of 81917f0

Powered by Codecov. Updated on successful CI builds.

@dlwalsh dlwalsh mentioned this pull request Apr 9, 2016
Closed
@hzoo hzoo added the PR: Internal 🏠 A type of pull request used for our changelog categories label Apr 21, 2016
@hzoo
Copy link
Copy Markdown
Member

hzoo commented May 13, 2016

Sorry for the delay, can you rebase/fix conflicts again? I think we can also remove trim-right and repeating in 2 other packages too then

@hzoo
Copy link
Copy Markdown
Member

hzoo commented May 13, 2016 •
edited
Loading

We're going to merge merged the lodash 4 pr #3315 so I think you'll need to modify the imports a bit

@dlwalsh
Copy link
Copy Markdown
Contributor Author

dlwalsh commented May 15, 2016

I'll do a fresh pull, redo the changes and submit another PR.

@dlwalsh dlwalsh closed this May 15, 2016
@loganfsmyth
Copy link
Copy Markdown
Member

loganfsmyth commented May 15, 2016

No need to close, you can just force-push a new version of this one.

@dlwalsh dlwalsh mentioned this pull request May 16, 2016
Merged
@dlwalsh
Copy link
Copy Markdown
Contributor Author

dlwalsh commented May 16, 2016 •
edited
Loading

I don't know how to do that. The new pull request is #3500.

@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

awaiting reply outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dlwalsh @codecov-io @hzoo @loganfsmyth