Skip to content

Remove micro dependencies in favour of lodash functions for babel-generator#3500

Merged
hzoo merged 1 commit intobabel:masterfrom
dlwalsh:remove-dependencies
May 16, 2016
Merged

Remove micro dependencies in favour of lodash functions for babel-generator#3500
hzoo merged 1 commit intobabel:masterfrom
dlwalsh:remove-dependencies

Conversation

@dlwalsh
Copy link
Copy Markdown
Contributor

@dlwalsh dlwalsh commented May 16, 2016

This is a revision of #3460, the following three modules have been replaced with their equivalent lodash 4 functions:

  • is-integer -> _.isInteger
  • repeating -> _.repeat
  • trim-right -> _.trimEnd

@hzoo hzoo merged commit 829d449 into babel:master May 16, 2016
@hzoo
Copy link
Copy Markdown
Member

hzoo commented May 16, 2016

Thanks! I think there's some more that can be replaced with lodash in the other packages too

@hzoo hzoo added the PR: Internal 🏠 A type of pull request used for our changelog categories label May 16, 2016
@dlwalsh dlwalsh deleted the remove-dependencies branch May 16, 2016 02:55
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants