Skip to content

Implement constantSuper, superIsCallableConstructor and noClassCalls assumption#12726

Merged
nicolo-ribaudo merged 5 commits into
babel:feat-7.13.0/babel-core-featuresfrom
nicolo-ribaudo:assumption/super
Feb 16, 2021
Merged

Implement constantSuper, superIsCallableConstructor and noClassCalls assumption#12726
nicolo-ribaudo merged 5 commits into
babel:feat-7.13.0/babel-core-featuresfrom
nicolo-ribaudo:assumption/super

Conversation

@nicolo-ribaudo

@nicolo-ribaudo nicolo-ribaudo commented Jan 31, 2021

Copy link
Copy Markdown
Member
Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Main PR: #12219
RFC: babel/rfcs#5

Please see babel/rfcs#5 (comment)!

@babel-bot

babel-bot commented Jan 31, 2021

Copy link
Copy Markdown
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/40624/

@codesandbox-ci

codesandbox-ci Bot commented Jan 31, 2021

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 41ea699:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@nicolo-ribaudo nicolo-ribaudo force-pushed the feat-7.13.0/babel-core-features branch from 5323795 to f1a6109 Compare February 4, 2021 22:44
@nicolo-ribaudo nicolo-ribaudo changed the title Implement constantSuper, superIsCallableConstructor and noCallClass assumption Implement constantSuper, superIsCallableConstructor and noClassCall assumption Feb 10, 2021
@nicolo-ribaudo nicolo-ribaudo force-pushed the feat-7.13.0/babel-core-features branch from 7d9f061 to a081c2a Compare February 10, 2021 19:17
@nicolo-ribaudo nicolo-ribaudo force-pushed the feat-7.13.0/babel-core-features branch from a081c2a to 3630b02 Compare February 11, 2021 23:34
@nicolo-ribaudo nicolo-ribaudo changed the title Implement constantSuper, superIsCallableConstructor and noClassCall assumption Implement constantSuper, superIsCallableConstructor and noClassCalls assumption Feb 11, 2021
@ExE-Boss

Copy link
Copy Markdown
Contributor

This needs rebasing to resolve merge conflicts with #12793.

Comment thread packages/babel-helper-create-class-features-plugin/src/fields.js Outdated
Co-authored-by: Justin Ridgewell <justin@ridgewell.name>
@nicolo-ribaudo nicolo-ribaudo merged commit d8392c3 into babel:feat-7.13.0/babel-core-features Feb 16, 2021
@nicolo-ribaudo nicolo-ribaudo deleted the assumption/super branch February 16, 2021 22:36
nicolo-ribaudo added a commit that referenced this pull request Feb 16, 2021
- `mutableTemplateObject` and `ignoreToPrimitiveHint` (#12408)
- `setClassMethods` (#12407)
- `setComputedProperties` (#12490)
- `ignoreFunctionLength` (#12491)
- `noDocumentAll` (#12481)
- `iterableIsArray` and `arrayLikeIsIterable` (#12489)
- `pureGetters` (#12504)
- `skipForOfIteratorClosing` (#12496)
- `objectRestNoSymbols`, `setSpreadProperties` and `pureGetters` (#12505)
- `noNewArrows` (#12613, #12793)
- `setPublicClassFields` and `privateFieldsAsProperties` (#12497)
- `constantReexports` and `enumerableModuleMeta` (#12618)
- `constantSuper`, `superIsCallableConstructor` and `noClassCalls` (#12726)

Co-authored-by: Justin Ridgewell <justin@ridgewell.name>
Co-authored-by: Huáng Jùnliàng <JLHwung@users.noreply.github.com>
nicolo-ribaudo added a commit that referenced this pull request Feb 16, 2021
- `mutableTemplateObject` and `ignoreToPrimitiveHint` (#12408)
- `setClassMethods` (#12407)
- `setComputedProperties` (#12490)
- `ignoreFunctionLength` (#12491)
- `noDocumentAll` (#12481)
- `iterableIsArray` and `arrayLikeIsIterable` (#12489)
- `pureGetters` (#12504)
- `skipForOfIteratorClosing` (#12496)
- `objectRestNoSymbols`, `setSpreadProperties` and `pureGetters` (#12505)
- `noNewArrows` (#12613, #12793)
- `setPublicClassFields` and `privateFieldsAsProperties` (#12497)
- `constantReexports` and `enumerableModuleMeta` (#12618)
- `constantSuper`, `superIsCallableConstructor` and `noClassCalls` (#12726)

Co-authored-by: Justin Ridgewell <justin@ridgewell.name>
Co-authored-by: Huáng Jùnliàng <JLHwung@users.noreply.github.com>
nicolo-ribaudo added a commit that referenced this pull request Feb 21, 2021
- `mutableTemplateObject` and `ignoreToPrimitiveHint` (#12408)
- `setClassMethods` (#12407)
- `setComputedProperties` (#12490)
- `ignoreFunctionLength` (#12491)
- `noDocumentAll` (#12481)
- `iterableIsArray` and `arrayLikeIsIterable` (#12489)
- `pureGetters` (#12504)
- `skipForOfIteratorClosing` (#12496)
- `objectRestNoSymbols`, `setSpreadProperties` and `pureGetters` (#12505)
- `noNewArrows` (#12613, #12793)
- `setPublicClassFields` and `privateFieldsAsProperties` (#12497)
- `constantReexports` and `enumerableModuleMeta` (#12618)
- `constantSuper`, `superIsCallableConstructor` and `noClassCalls` (#12726)

Co-authored-by: Justin Ridgewell <justin@ridgewell.name>
Co-authored-by: Huáng Jùnliàng <JLHwung@users.noreply.github.com>
@github-actions github-actions Bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label May 19, 2021
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area: assumptions outdated A closed issue/PR that is archived due to age. Recommended to make a new issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants