Implement iterableIsArray and arrayLikeIsIterable assumptions#12489
Merged
nicolo-ribaudo merged 3 commits intoDec 14, 2020
Merged
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/34972/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1e64d8f:
|
24 tasks
- transform-destructuring - transform-for-of - transform-spread
- transform-destructuring - transform-for-of - transform-spread
1e64d8f to
a029176
Compare
JLHwung
approved these changes
Dec 11, 2020
JLHwung
left a comment
Contributor
There was a problem hiding this comment.
Are we going to rename allowArrayLike to arrayLikeIsIterable in Babel 8?
Member
Author
|
If we keep it yes; I'm not sure if it's it worth to keep it around given the new |
hzoo
approved these changes
Dec 14, 2020
jridgewell
reviewed
Dec 15, 2020
| const arrayOnlySpread = loose; | ||
| const iterableIsArray = api.assumption("iterableIsArray") ?? options.loose; | ||
| const arrayLikeIsIterable = | ||
| options.allowArrayLike ?? api.assumption("arrayLikeIsIterable"); |
jridgewell
reviewed
Dec 15, 2020
| const { loose, allowArrayLike } = options; | ||
| const iterableIsArray = api.assumption("iterableIsArray") ?? options.loose; | ||
| const arrayLikeIsIterable = | ||
| options.allowArrayLike ?? api.assumption("arrayLikeIsIterable"); |
Member
Author
There was a problem hiding this comment.
The reason for swapping the order here is that, while loose is generic (and thus it's good to keep it as a fallback value), this option was explicitly designed for this assumption and it has a quite specific name. Thus I followed the "locality principle": since they have the same specificity, the option closer to the plugin has the precedence.
I wasn't 100% sure of doing this, so I'm open to change it to match loose's behavior if no one else thinks that options.allowArrayLike should take precedence.
Contributor
There was a problem hiding this comment.
It makes sense to me that when options.allowArrayLike is specified, that it should take precedence over api.assumption("arrayLikeIsIterable").
nicolo-ribaudo
added a commit
to nicolo-ribaudo/babel
that referenced
this pull request
Jan 12, 2021
nicolo-ribaudo
added a commit
that referenced
this pull request
Jan 24, 2021
nicolo-ribaudo
added a commit
that referenced
this pull request
Jan 24, 2021
nicolo-ribaudo
added a commit
to nicolo-ribaudo/babel
that referenced
this pull request
Feb 4, 2021
nicolo-ribaudo
added a commit
to nicolo-ribaudo/babel
that referenced
this pull request
Feb 10, 2021
nicolo-ribaudo
added a commit
to nicolo-ribaudo/babel
that referenced
this pull request
Feb 11, 2021
nicolo-ribaudo
added a commit
that referenced
this pull request
Feb 16, 2021
- `mutableTemplateObject` and `ignoreToPrimitiveHint` (#12408) - `setClassMethods` (#12407) - `setComputedProperties` (#12490) - `ignoreFunctionLength` (#12491) - `noDocumentAll` (#12481) - `iterableIsArray` and `arrayLikeIsIterable` (#12489) - `pureGetters` (#12504) - `skipForOfIteratorClosing` (#12496) - `objectRestNoSymbols`, `setSpreadProperties` and `pureGetters` (#12505) - `noNewArrows` (#12613, #12793) - `setPublicClassFields` and `privateFieldsAsProperties` (#12497) - `constantReexports` and `enumerableModuleMeta` (#12618) - `constantSuper`, `superIsCallableConstructor` and `noClassCalls` (#12726) Co-authored-by: Justin Ridgewell <justin@ridgewell.name> Co-authored-by: Huáng Jùnliàng <JLHwung@users.noreply.github.com>
nicolo-ribaudo
added a commit
that referenced
this pull request
Feb 16, 2021
- `mutableTemplateObject` and `ignoreToPrimitiveHint` (#12408) - `setClassMethods` (#12407) - `setComputedProperties` (#12490) - `ignoreFunctionLength` (#12491) - `noDocumentAll` (#12481) - `iterableIsArray` and `arrayLikeIsIterable` (#12489) - `pureGetters` (#12504) - `skipForOfIteratorClosing` (#12496) - `objectRestNoSymbols`, `setSpreadProperties` and `pureGetters` (#12505) - `noNewArrows` (#12613, #12793) - `setPublicClassFields` and `privateFieldsAsProperties` (#12497) - `constantReexports` and `enumerableModuleMeta` (#12618) - `constantSuper`, `superIsCallableConstructor` and `noClassCalls` (#12726) Co-authored-by: Justin Ridgewell <justin@ridgewell.name> Co-authored-by: Huáng Jùnliàng <JLHwung@users.noreply.github.com>
nicolo-ribaudo
added a commit
that referenced
this pull request
Feb 21, 2021
- `mutableTemplateObject` and `ignoreToPrimitiveHint` (#12408) - `setClassMethods` (#12407) - `setComputedProperties` (#12490) - `ignoreFunctionLength` (#12491) - `noDocumentAll` (#12481) - `iterableIsArray` and `arrayLikeIsIterable` (#12489) - `pureGetters` (#12504) - `skipForOfIteratorClosing` (#12496) - `objectRestNoSymbols`, `setSpreadProperties` and `pureGetters` (#12505) - `noNewArrows` (#12613, #12793) - `setPublicClassFields` and `privateFieldsAsProperties` (#12497) - `constantReexports` and `enumerableModuleMeta` (#12618) - `constantSuper`, `superIsCallableConstructor` and `noClassCalls` (#12726) Co-authored-by: Justin Ridgewell <justin@ridgewell.name> Co-authored-by: Huáng Jùnliàng <JLHwung@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main PR: #12219
RFC: babel/rfcs#5
Picking the correct defaults was hard in this PR, so please check if what I did makes sense.